From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMJ9S-0005UK-BD for qemu-devel@nongnu.org; Wed, 18 Sep 2013 10:54:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMJ9J-0000pK-VF for qemu-devel@nongnu.org; Wed, 18 Sep 2013 10:54:46 -0400 Received: from mail-ob0-x229.google.com ([2607:f8b0:4003:c01::229]:45995) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMJ9J-0000p7-PI for qemu-devel@nongnu.org; Wed, 18 Sep 2013 10:54:37 -0400 Received: by mail-ob0-f169.google.com with SMTP id wp4so7822712obc.0 for ; Wed, 18 Sep 2013 07:54:37 -0700 (PDT) Sender: Richard Henderson Message-ID: <5239BEA8.2080908@twiddle.net> Date: Wed, 18 Sep 2013 07:54:32 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1379195690-6509-1-git-send-email-rth@twiddle.net> <1379195690-6509-9-git-send-email-rth@twiddle.net> <5236C44C.7060405@huawei.com> <52372479.3080807@twiddle.net> <52381167.9020800@huawei.com> <52386D08.8090307@twiddle.net> <52396335.5010800@huawei.com> In-Reply-To: <52396335.5010800@huawei.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 08/33] tcg-aarch64: Introduce tcg_fmt_Rdnm and tcg_fmt_Rdnm_lsl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Claudio Fontana Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org On 09/18/2013 01:24 AM, Claudio Fontana wrote: > If you _really_ want to strip the right shift functionality away for some reason, could you state it? (1) It will never never ever be used. (2) I do not find + for LSR, - for LSL intuitive at all. If we're to have them at all, better to pass that separately from the shift count, an enumeration that exactly maps to the "shift" field in the insn. (3) It will never never ever be used. r~