From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Marcel Apfelbaum <marcel.a@redhat.com>
Subject: Re: [Qemu-devel] [Question] memory: AddressSpace backed by single IO MemoryRegion
Date: Wed, 18 Sep 2013 17:43:36 +0200 [thread overview]
Message-ID: <5239CA28.1030401@redhat.com> (raw)
In-Reply-To: <CAFEAcA-UrR1BDCujn1=y1HX+LrO280LtJycEXiwQM46FGnBzEA@mail.gmail.com>
Il 17/09/2013 10:29, Peter Maydell ha scritto:
> On 16 September 2013 18:18, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 16/09/2013 19:11, Marcel Apfelbaum ha scritto:
>>>>> memory_region_init_io(my_reg, owner, my_ops, my_obj, "my region", INT64_MAX);
>>
>> This is 2^63-1, not 2^64-1. You need UINT64_MAX here.
>
> So does this mean address_space_init()'s base memory
> region has to be 2^64-1 (could we assert that?) or should
> this have worked anyway?
No, it probably means that it must be page-aligned.
It should have worked anyway, but I'm not 100% sure without looking more
at the code. It's a somewhat obscure corner case.
Paolo
prev parent reply other threads:[~2013-09-18 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 14:48 [Qemu-devel] [Question] memory: AddressSpace backed by single IO MemoryRegion Marcel Apfelbaum
2013-09-16 14:52 ` Paolo Bonzini
2013-09-16 15:27 ` Marcel Apfelbaum
2013-09-16 17:11 ` Marcel Apfelbaum
2013-09-16 17:18 ` Paolo Bonzini
2013-09-16 17:26 ` Marcel Apfelbaum
2013-09-17 8:29 ` Peter Maydell
2013-09-18 15:43 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5239CA28.1030401@redhat.com \
--to=pbonzini@redhat.com \
--cc=marcel.a@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).