From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMJuf-0005oX-L2 for qemu-devel@nongnu.org; Wed, 18 Sep 2013 11:43:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMJuZ-0000M9-MJ for qemu-devel@nongnu.org; Wed, 18 Sep 2013 11:43:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMJuZ-0000M2-EP for qemu-devel@nongnu.org; Wed, 18 Sep 2013 11:43:27 -0400 Message-ID: <5239CA28.1030401@redhat.com> Date: Wed, 18 Sep 2013 17:43:36 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1379342904.17705.69.camel@localhost.localdomain> <52371B45.8000508@redhat.com> <1379351503.17705.77.camel@localhost.localdomain> <52373D5A.2050004@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Question] memory: AddressSpace backed by single IO MemoryRegion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Marcel Apfelbaum Il 17/09/2013 10:29, Peter Maydell ha scritto: > On 16 September 2013 18:18, Paolo Bonzini wrote: >> Il 16/09/2013 19:11, Marcel Apfelbaum ha scritto: >>>>> memory_region_init_io(my_reg, owner, my_ops, my_obj, "my region", INT64_MAX); >> >> This is 2^63-1, not 2^64-1. You need UINT64_MAX here. > > So does this mean address_space_init()'s base memory > region has to be 2^64-1 (could we assert that?) or should > this have worked anyway? No, it probably means that it must be page-aligned. It should have worked anyway, but I'm not 100% sure without looking more at the code. It's a somewhat obscure corner case. Paolo