From: Peter Lieven <pl@kamp.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PULL 08/11] iscsi: add .bdrv_get_block_status
Date: Thu, 19 Sep 2013 09:24:16 +0200 [thread overview]
Message-ID: <523AA6A0.1060209@kamp.de> (raw)
In-Reply-To: <52388F81.7030102@redhat.com>
On 17.09.2013 19:21, Paolo Bonzini wrote:
> Il 17/09/2013 19:18, Stefan Weil ha scritto:
>> Latest QEMU git is broken on Debian wheezy:
>>
>> block/iscsi.c: In function ‘iscsi_co_get_block_status’:
>> block/iscsi.c:842:5: error: implicit declaration of function
>> ‘iscsi_get_lba_status_task’ [-Werror=implicit-function-declaration]
>> block/iscsi.c:842:5: error: nested extern declaration of
>> ‘iscsi_get_lba_status_task’ [-Werror=nested-externs]
>> block/iscsi.c:845:43: error: comparison between pointer and integer
>> [-Werror]
>> block/iscsi.c:877:18: error: dereferencing pointer to incomplete type
>> block/iscsi.c:879:55: error: dereferencing pointer to incomplete type
>> block/iscsi.c:884:34: error: dereferencing pointer to incomplete type
>> block/iscsi.c:889:14: error: dereferencing pointer to incomplete type
>> block/iscsi.c:889:32: error: ‘SCSI_PROVISIONING_TYPE_DEALLOCATED’
>> undeclared (first use in this function)
>> block/iscsi.c:889:32: note: each undeclared identifier is reported only
>> once for each function it appears in
>> block/iscsi.c:890:14: error: dereferencing pointer to incomplete type
>> block/iscsi.c:890:32: error: ‘SCSI_PROVISIONING_TYPE_ANCHORED’
>> undeclared (first use in this function)
>> cc1: all warnings being treated as errors
>>
>> Debian includes libiscsi-dev 1.4.0 without a libiscsi.pk, so it uses a
>> compile test
>> which thinks that libiscsi is good enough.
>>
>> Did the latest changes raise the requirements for libscsi?
> Looks like. Can you make a patch that drops the definition of
> iscsi_co_get_block_status if SCSI_PROVISIONING_TYPE_DEALLOCATED is not
> #defined?
>
> Thanks,
>
> Paolo
do we still need this patch? if yes I can sent one shortly.
Peter
next prev parent reply other threads:[~2013-09-19 7:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 11:17 [Qemu-devel] [PULL 00/11] SCSI patches for 2013-09-11 Paolo Bonzini
2013-09-12 11:17 ` [Qemu-devel] [PULL 01/11] scsi: prefer UUID to VM name for the initiator name Paolo Bonzini
2013-09-12 11:17 ` [Qemu-devel] [PULL 02/11] spapr-vscsi: add task management Paolo Bonzini
2013-09-12 11:17 ` [Qemu-devel] [PULL 03/11] virtio-scsi: Make type virtio-scsi-common abstract Paolo Bonzini
2013-09-12 11:17 ` [Qemu-devel] [PULL 04/11] scsi: Fix scsi_bus_legacy_add_drive() scsi-generic with serial Paolo Bonzini
2013-09-12 11:17 ` [Qemu-devel] [PULL 05/11] hw/scsi/lsi53c895a: Use sextract32 for sign-extension Paolo Bonzini
2013-09-12 11:17 ` [Qemu-devel] [PULL 06/11] hw/scsi/lsi53c895a: Use deposit32 rather than handcoded shift/mask Paolo Bonzini
2013-09-12 11:17 ` [Qemu-devel] [PULL 07/11] iscsi: add logical block provisioning information to iscsilun Paolo Bonzini
2013-09-12 11:17 ` [Qemu-devel] [PULL 08/11] iscsi: add .bdrv_get_block_status Paolo Bonzini
2013-09-17 17:18 ` Stefan Weil
2013-09-17 17:21 ` Paolo Bonzini
2013-09-19 7:24 ` Peter Lieven [this message]
2013-09-19 13:46 ` Paolo Bonzini
2013-10-02 11:37 ` Peter Lieven
2013-09-12 11:17 ` [Qemu-devel] [PULL 09/11] iscsi: split discard requests in multiple parts Paolo Bonzini
2013-09-12 11:17 ` [Qemu-devel] [PULL 10/11] spapr-vscsi: Adding VSCSI capabilities Paolo Bonzini
2013-09-12 11:17 ` [Qemu-devel] [PULL 11/11] spapr-vscsi: Report error on unsupported MAD requests Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523AA6A0.1060209@kamp.de \
--to=pl@kamp.de \
--cc=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).