From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMcwm-0000w2-17 for qemu-devel@nongnu.org; Thu, 19 Sep 2013 08:03:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMcwd-00050Z-SB for qemu-devel@nongnu.org; Thu, 19 Sep 2013 08:02:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMcwd-00050A-DB for qemu-devel@nongnu.org; Thu, 19 Sep 2013 08:02:51 -0400 Message-ID: <523AE7E0.4050503@redhat.com> Date: Thu, 19 Sep 2013 06:02:40 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379425736-11326-1-git-send-email-pl@kamp.de> <1379425736-11326-4-git-send-email-pl@kamp.de> In-Reply-To: <1379425736-11326-4-git-send-email-pl@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IKX6XMPx9rdIL427SiAwXLCg3EHeR0hSk" Subject: Re: [Qemu-devel] [PATCHv2 03/20] block: introduce BDRV_REQ_MAY_UNMAP request flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IKX6XMPx9rdIL427SiAwXLCg3EHeR0hSk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/17/2013 07:48 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block-migration.c | 3 ++- > block.c | 4 ++++ > block/backup.c | 2 +- > include/block/block.h | 7 +++++++ > 4 files changed, 14 insertions(+), 2 deletions(-) > +++ b/include/block/block.h > @@ -65,6 +65,13 @@ typedef struct BlockDevOps { > typedef enum { > BDRV_REQ_COPY_ON_READ =3D 0x1, > BDRV_REQ_ZERO_WRITE =3D 0x2, > + /* the BDRV_REQ_MAY_UNMAP flag is used to indicate that block driv= er Minor grammar improvements: s/the/The/ s/that/that the/ > + * is allowed to optimize a write zeroes request by unmapping (dis= carding) > + * blocks if it is guaranteed that the result will read back as > + * zeroes. the flag is only passed to the driver if the block devi= ce is s/the flag/The flag/ > + * opened with BDRV_O_UNMAP. > + */ > + BDRV_REQ_MAY_UNMAP =3D 0x4, As those are trivial, feel free to add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --IKX6XMPx9rdIL427SiAwXLCg3EHeR0hSk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSOufgAAoJEKeha0olJ0NqQBAH/j7BwrUO1ow287ZS5OOVCcpr EXqXdTCeq00a9D4zWdCtI5SEX9WgaVabx8ZGb72Fv6m1wAk/yEvI1rQgPoKl9XAS h5ywY7SggzHVYx6XHvQ7ospixMXtJvYipiYRAOo7AyRMTf00UP1xDI23Gid3y1py 6c/mPMGVmXMJ1Qw4M3ALOzfinbood3qm72sMrWjGSgt9aJT2qlsCzU/X5cY7AzuG WKi8xy481J6tiegE9KRu/tw3o7Nrm0lxggc7PcYV9MueSIIyZUOeHmgC8RqUQJAc t2PdHHUtVW7XoPWK+54YefTIdSxnB6g0ggX2VlsjqneljwwbPtEpmFZmkCH4GPk= =v27y -----END PGP SIGNATURE----- --IKX6XMPx9rdIL427SiAwXLCg3EHeR0hSk--