From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50226)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VMfT9-0008R3-En
	for qemu-devel@nongnu.org; Thu, 19 Sep 2013 10:44:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VMfT4-0003pa-Ie
	for qemu-devel@nongnu.org; Thu, 19 Sep 2013 10:44:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17778)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VMfT4-0003pT-AO
	for qemu-devel@nongnu.org; Thu, 19 Sep 2013 10:44:30 -0400
Message-ID: <523B0DC9.6020502@redhat.com>
Date: Thu, 19 Sep 2013 16:44:25 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1379425736-11326-1-git-send-email-pl@kamp.de>
	<1379425736-11326-21-git-send-email-pl@kamp.de>
	<523968F8.3080808@redhat.com> <523AA7C2.4010000@kamp.de>
In-Reply-To: <523AA7C2.4010000@kamp.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv2 20/20] block/raw: copy block limits and
 alignment information on raw_open
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws

Il 19/09/2013 09:29, Peter Lieven ha scritto:
> On 18.09.2013 10:48, Paolo Bonzini wrote:
>> Il 17/09/2013 15:48, Peter Lieven ha scritto:
>>> Signed-off-by: Peter Lieven <pl@kamp.de>
>>> ---
>>>   block/raw_bsd.c |    4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/block/raw_bsd.c b/block/raw_bsd.c
>>> index 0bfa5fc..dfdb375 100644
>>> --- a/block/raw_bsd.c
>>> +++ b/block/raw_bsd.c
>>> @@ -149,6 +149,10 @@ static int raw_create(const char *filename,
>>> QEMUOptionParameter *options)
>>>   static int raw_open(BlockDriverState *bs, QDict *options, int flags)
>>>   {
>>>       bs->sg = bs->file->sg;
>>> +    bs->max_discard = bs->file->max_discard;
>>> +    bs->discard_alignment = bs->file->discard_alignment;
>>> +    bs->max_write_zeroes = bs->file->max_write_zeroes;
>>> +    bs->write_zeroes_alignment = bs->file->write_zeroes_alignment;
>>>       return 0;
>> What about introducing a BlockLimits struct?
> Good idea.
> 
> Do you like the rest of the series?

Yes, I do.

Paolo