From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMfaC-00059a-DR for qemu-devel@nongnu.org; Thu, 19 Sep 2013 10:51:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMfa7-00067M-GI for qemu-devel@nongnu.org; Thu, 19 Sep 2013 10:51:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMfa7-000676-73 for qemu-devel@nongnu.org; Thu, 19 Sep 2013 10:51:47 -0400 Message-ID: <523B0F7B.5060204@redhat.com> Date: Thu, 19 Sep 2013 08:51:39 -0600 From: Eric Blake MIME-Version: 1.0 References: <20130917124413.GA822@stefanha-thinkpad.str.redhat.com> <20130918150527.GA5025@irqsave.net> <20130919082653.GC22814@stefanha-thinkpad.redhat.com> <20130919085750.GA3631@dhcp-200-207.str.redhat.com> <20130919125536.GA12498@irqsave.net> <20130919132146.GB3631@dhcp-200-207.str.redhat.com> In-Reply-To: <20130919132146.GB3631@dhcp-200-207.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CnG4othqJc4EJKbtLT7rxbEaWwUEgvD2e" Subject: Re: [Qemu-devel] Merging the quorum block driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Stefan Hajnoczi , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CnG4othqJc4EJKbtLT7rxbEaWwUEgvD2e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/19/2013 07:21 AM, Kevin Wolf wrote: >=20 > I was thinking more along the lines of: >=20 > -drive if=3Dnone,file.driver=3Dquorum,format=3Draw,\ > file.children[0].file.filename=3D/nfs1/test.qcow2, \ Note that this requires shell quoting to protect you from globbing changing the argv handed to qemu based on an (unusual) file name in the current directory. Not necessarily the end of the world (someone like libvirt that uses exec rather than a shell command line isn't bothered by it, and the command line is so long that most users will not be typing it directly), but worth thinking about whether we can come up with an alternate syntax that doesn't require shell quoting. (As is, your use of \-newline and whitespace is not quite right for how the actual command line would appear; but it does make discussion easier in the meantime) > The exact syntax doesn't matter all that much as long as it can be > mapped to QAPI, but as you can see this allows specifying detailed > options even for the children. I think this is a requirement. Indeed, those aspects (mappability to QAPI, and fine-tuning of each child) are essential. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CnG4othqJc4EJKbtLT7rxbEaWwUEgvD2e Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSOw97AAoJEKeha0olJ0NqkkEIAKywKA37V+GTkGB+PR+o2uWZ vUYoPXszH+4sH+xMziEYon6sTlOa6NWEeu4Lp3FZbHmIsCxbuz8NI7OAsOSXnZnu whsMLOH/KuTqjpsNdJ9Rzo6nLotv1N5PMNsRI9yD96lQBAw+ng4S3U1w709k43Bt iMyozkp7ypIZNjG3CuTH5Inof3nYSMLUzsHDkS16V5Q/Qh+04BNqs7mgOj0hRRCD 2+HXYpC5yXkRr17zONbdjPZ12SIZX3E5kH+QhQwmnFhSUjwEqmcIei14it+WqPQp sTX+RqMFxPtAodA5DAHg4QbMgSOuE2qD1xhnNNRH4nLLheW1l3pd3xj1b+skHrk= =oXcT -----END PGP SIGNATURE----- --CnG4othqJc4EJKbtLT7rxbEaWwUEgvD2e--