From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Igor Mammedov" <imammedo@redhat.com>,
"Bandan Das" <bsd@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Gleb Natapov" <gleb@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC] Enabling x2apic on most (all?) x86 CPU models
Date: Thu, 19 Sep 2013 19:19:10 +0200 [thread overview]
Message-ID: <523B320E.4060107@redhat.com> (raw)
In-Reply-To: <20130919165855.GO2840@otherpad.lan.raisama.net>
Il 19/09/2013 18:58, Eduardo Habkost ha scritto:
>> >
>> > I disagree, since this would also affect TCG. I would prefer to add
>> > x2apic only to models that really have it and would be open to generally
>> > enabling it for kvm_enabled() in instance_init/registration (so that
>> > users can disable it via ,-x2apic or soon QMP).
> This won't affect TCG because features not supported by TCG are removed
> automatically, and "enforce" doesn't even work on TCG mode (yet).
>
> I believe we agreed that we don't want to make the semantics of CPU
> model names change depending if KVM or TCG are enabled[1], so I am
> trying to avoid making the default depend on kvm_enabled().
I agree. I don't think it would matter much if one day TCG starts
supporting x2apic (it's probably only a few hours work) and old CPUs
started showing x2apic.
Paolo
prev parent reply other threads:[~2013-09-19 17:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 20:39 [Qemu-devel] [RFC] Enabling x2apic on most (all?) x86 CPU models Eduardo Habkost
2013-09-19 11:50 ` Andreas Färber
2013-09-19 16:58 ` Eduardo Habkost
2013-09-19 17:19 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523B320E.4060107@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=bsd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=gleb@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).