From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMi6M-0000bp-Ma for qemu-devel@nongnu.org; Thu, 19 Sep 2013 13:33:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMi6G-0004UI-Uf for qemu-devel@nongnu.org; Thu, 19 Sep 2013 13:33:14 -0400 Message-ID: <523B3550.3070507@redhat.com> Date: Thu, 19 Sep 2013 11:33:04 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379609334-20811-1-git-send-email-pbonzini@redhat.com> <1379609334-20811-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1379609334-20811-2-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="M3EpMd09cKASf6a1g5NijHqOeATRMTVmO" Subject: Re: [Qemu-devel] [PATCH 1/2] blockdev: do not default cache.no-flush to true List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, rusty@au1.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com, qemu-stable@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --M3EpMd09cKASf6a1g5NijHqOeATRMTVmO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/19/2013 10:48 AM, Paolo Bonzini wrote: > That's why all my VMs were so fast lately. :) >=20 > This changed in 1.6.0 by mistake in patch 29c4e2b (blockdev: Split up > 'cache' option, 2013-07-18). And my name is tied to that one as a reviewer. Sorry for letting it through in the first place. >=20 > Cc: qemu-stable@nongnu.org > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/blockdev.c b/blockdev.c > index 07dac05..76bfe30 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -443,7 +443,7 @@ static DriveInfo *blockdev_init(QemuOpts *all_opts,= > if (qemu_opt_get_bool(opts, "cache.direct", false)) { > bdrv_flags |=3D BDRV_O_NOCACHE; > } > - if (qemu_opt_get_bool(opts, "cache.no-flush", true)) { > + if (qemu_opt_get_bool(opts, "cache.no-flush", false)) { > bdrv_flags |=3D BDRV_O_NO_FLUSH; > } > =20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --M3EpMd09cKASf6a1g5NijHqOeATRMTVmO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSOzVQAAoJEKeha0olJ0NqIEwH/Ra/bdRk4tZBHJ8CdH439Yk2 mdcTmW+++/DpHlTKPoJa59DOsC5KwaID7whUBDDvq/hi7c6RUCOf8nPdNk8v5DgY VTgOZ/BsB723HxDPeMLNYOe3hfSG6bvFcU7ooiCAO/UI2Tk2+0xl6iMk1Y6IOTZO IRmhxCBKmzaKYHSnNi0an+kSeTfbdiIXeTbrOa3lORxYgF8SnXmj0NWUI3Aq+Fl2 H+E9uzB1jPkWF2toMjBv7TLo0ELWl/fVMKNuiXC/0kCj2yLm9+KI0ilFY03X+bIM mia+2p5cQgbeAMix6EXzA4MjOBPEpLG1N465EwDi+p9mmDJwYiy1JiPpJideg9k= =JqXm -----END PGP SIGNATURE----- --M3EpMd09cKASf6a1g5NijHqOeATRMTVmO--