From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMjLz-0001z0-V8 for qemu-devel@nongnu.org; Thu, 19 Sep 2013 14:53:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMjLv-0003iM-Hi for qemu-devel@nongnu.org; Thu, 19 Sep 2013 14:53:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMjLv-0003iI-9j for qemu-devel@nongnu.org; Thu, 19 Sep 2013 14:53:23 -0400 Message-ID: <523B481C.50405@redhat.com> Date: Thu, 19 Sep 2013 12:53:16 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379425736-11326-1-git-send-email-pl@kamp.de> <1379425736-11326-7-git-send-email-pl@kamp.de> In-Reply-To: <1379425736-11326-7-git-send-email-pl@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SrjRthc7wTlLTPhvuRVEqhRiXk4afbRxP" Subject: Re: [Qemu-devel] [PATCHv2 06/20] block: add discard and write_zeroes limits and alignment to BlockDriverState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SrjRthc7wTlLTPhvuRVEqhRiXk4afbRxP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/17/2013 07:48 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > include/block/block_int.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) Reviewed-by: Eric Blake > + > + /* optimal alignment for write zeroes requests in sectors */ > + int64_t write_zeroes_alignment; > + > /* do we need to tell the quest if we have a volatile write cache?= */ > int enable_write_cache; Hmm, I just pointed out to Paolo that this ought to be bool. But as it is in the context and not your actual patch, it has no bearing on this series, and even if that gets changed first, git's pretty good about context-only conflict resolution. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SrjRthc7wTlLTPhvuRVEqhRiXk4afbRxP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSO0gcAAoJEKeha0olJ0NqpTEIAJ2Ae+1ADCMHptVB57hkh5Aj N87+MJ2RwTPHa12NNRHR2ylh+kzToQ3wZkRJ3A4p4KLAYb8EMmTZ22yhZPQ3vd9S ekRt5Eo7Qi37mE1Zx4RzCAm+iPSoj7U4+l+Cn36+Gu1pzRfipf5OT7p+dq5r28pj TIGM7yH+jcSXVUEUXNJ0HqX8RDlWULh5oVFIpVcuqnO8/li6mB3+LTacxivFpEC4 ynK5Lo4MJcpfGXf64yTaVJCiYKZp2m2xNoaQYRNW7rzQAsPGK94hMnZYAOjwhjIE +o6kDn6/nFAjDSagyrhW7ui8y7+F54Ks+Rj5fUm1Qp3z9OQ7PWeuRrxtKxQu8do= =8S7Q -----END PGP SIGNATURE----- --SrjRthc7wTlLTPhvuRVEqhRiXk4afbRxP--