From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMkfC-0008LO-23 for qemu-devel@nongnu.org; Thu, 19 Sep 2013 16:17:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMkf7-0002eT-LN for qemu-devel@nongnu.org; Thu, 19 Sep 2013 16:17:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMkf7-0002eM-Bi for qemu-devel@nongnu.org; Thu, 19 Sep 2013 16:17:17 -0400 Message-ID: <523B5BC6.3030501@redhat.com> Date: Thu, 19 Sep 2013 14:17:10 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379425736-11326-1-git-send-email-pl@kamp.de> <1379425736-11326-12-git-send-email-pl@kamp.de> In-Reply-To: <1379425736-11326-12-git-send-email-pl@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XRHCxk7RnMMHnQVk9v3o2sGnITFA6k3AW" Subject: Re: [Qemu-devel] [PATCHv2 11/20] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XRHCxk7RnMMHnQVk9v3o2sGnITFA6k3AW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/17/2013 07:48 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/iscsi.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) >=20 > @@ -1522,7 +1534,9 @@ static BlockDriver bdrv_iscsi =3D { > .bdrv_aio_writev =3D iscsi_aio_writev, > .bdrv_aio_flush =3D iscsi_aio_flush, > =20 > - .bdrv_has_zero_init =3D iscsi_has_zero_init, > + .bdrv_has_zero_init =3D iscsi_has_zero_init, > + .bdrv_has_discard_zeroes =3D iscsi_has_discard_zeroes , Spurious space before ','. As that's trivial to fix, feel free to add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XRHCxk7RnMMHnQVk9v3o2sGnITFA6k3AW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSO1vGAAoJEKeha0olJ0NqkssH/0UL/d7Pm1I/rIM2oNMvMVDQ KHmOqfLIM+1TyalPF6EtQjwVjzBDW37iP+u4LhFLv85RdJ5DECvHUQd07lCWtggn OSPy0lZXPBxi8YoEBjs/SEhOSpxUvXwM5IG7SRGtUgxM7wgkrtbhA0YXy56nvMmP 6zvoRGnMWheCjqkJmMYRuUdGdwRKLQboA0REBMYYD30EsSOXyQn10RjAhzKInQVt DVaRdQRcGSi6p2Pqqf9dJmAtDOJg+aUMMQbw6y1aPJOI5lordLPXqf1E6Rbe2Ayn Qk4R3fE9y1c8G3iQ79aRlgYI3jZc1NAHKfaKaC9U1zie2rs+hc2Y/aHhF1fXV4s= =R8qo -----END PGP SIGNATURE----- --XRHCxk7RnMMHnQVk9v3o2sGnITFA6k3AW--