From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMl0R-0008KW-UG for qemu-devel@nongnu.org; Thu, 19 Sep 2013 16:39:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMl0N-0008Mg-Gw for qemu-devel@nongnu.org; Thu, 19 Sep 2013 16:39:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMl0N-0008MF-9B for qemu-devel@nongnu.org; Thu, 19 Sep 2013 16:39:15 -0400 Message-ID: <523B60EC.30202@redhat.com> Date: Thu, 19 Sep 2013 14:39:08 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379425736-11326-1-git-send-email-pl@kamp.de> <1379425736-11326-20-git-send-email-pl@kamp.de> In-Reply-To: <1379425736-11326-20-git-send-email-pl@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F4sj0u6cLiGtihO0xP1UeXP4RLRDFitB5" Subject: Re: [Qemu-devel] [PATCHv2 19/20] qemu-img: conditionally zero out target on convert List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --F4sj0u6cLiGtihO0xP1UeXP4RLRDFitB5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/17/2013 07:48 AM, Peter Lieven wrote: > if the target has_zero_init =3D 0, but supports efficiently > writing zeroes by unmapping we call bdrv_zeroize to > avoid fully allocating the target. this currently You don't like the shift key, do you? :) s/this/This/ if you care about grammar in commit messages (I care about it in user-visible strings, but am more than willing to let it slide in commit messages) > is designed especially for iscsi. >=20 > Signed-off-by: Peter Lieven > --- > qemu-img.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --F4sj0u6cLiGtihO0xP1UeXP4RLRDFitB5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSO2DsAAoJEKeha0olJ0NqnVcIAJPBPAXTLf5AQkqN0p2m80L2 zaXJ7NNySjkHrYxKWxzY0+niB/Z8Xyj1JGTKBLRRP172cJIn1GuXcZy7afgFUkyg xf9823IVT4SVwqJmSTCSuo3mMHGrwBnQk0JO3OSAhrgK46B+g4DcqR1skrGSuYrQ EaUHzYCN5a6ov8KePpY/A8Ws367AnGpo17/x2Lj3m8wP4Nyn3gOTwnwTNwZjobWg Yzu8HY9lyw1gZxmEPQV2PtvUIzFF1ahantru9WFmxVMs8eZjQLbVRF4/keR+sL4J kwzeXZgxLNX5Lff6yxpixlVI0LUYGDlV3jJUMd/3w7WW+feZx5Vy1aWum8O41Ro= =hMec -----END PGP SIGNATURE----- --F4sj0u6cLiGtihO0xP1UeXP4RLRDFitB5--