From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN1Qf-0007uL-2w for qemu-devel@nongnu.org; Fri, 20 Sep 2013 10:11:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN1QU-0006En-Tc for qemu-devel@nongnu.org; Fri, 20 Sep 2013 10:11:29 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:52434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN1QU-0006Ei-Ea for qemu-devel@nongnu.org; Fri, 20 Sep 2013 10:11:18 -0400 Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 20 Sep 2013 08:11:18 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id EFF991FF001C for ; Fri, 20 Sep 2013 08:11:11 -0600 (MDT) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8KEBGxl130244 for ; Fri, 20 Sep 2013 08:11:16 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r8KEBGBb028920 for ; Fri, 20 Sep 2013 08:11:16 -0600 Message-ID: <523C5779.4010309@linux.vnet.ibm.com> Date: Fri, 20 Sep 2013 10:11:05 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <5d53d839653bf4fd24d5cb56f6d24d3dc3f8f8a5.1378261891.git.yamahata@private.email.ne.jp> <5239B8A3.10305@linux.vnet.ibm.com> <20130920075546.GP16551@valinux.co.jp> In-Reply-To: <20130920075546.GP16551@valinux.co.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] rdma: constify ram_chunk_{index, start, end} List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: qemu-devel@nongnu.org, owasserm@redhat.com, pbonzini@redhat.com, mrhines@us.ibm.com, quintela@redhat.com On 09/20/2013 03:55 AM, Isaku Yamahata wrote: > On Wed, Sep 18, 2013 at 10:28:51AM -0400, Michael R. Hines wrote: >> On 09/03/2013 10:32 PM, Isaku Yamahata wrote: >>> Signed-off-by: Isaku Yamahata >>> --- >>> migration-rdma.c | 8 +++++--- >>> 1 file changed, 5 insertions(+), 3 deletions(-) >>> >>> diff --git a/migration-rdma.c b/migration-rdma.c >>> index e71c10a..db5a908 100644 >>> --- a/migration-rdma.c >>> +++ b/migration-rdma.c >>> @@ -511,19 +511,21 @@ static int qemu_rdma_exchange_send(RDMAContext *rdma, RDMAControlHeader *head, >>> int *resp_idx, >>> int (*callback)(RDMAContext *rdma)); >>> >>> -static inline uint64_t ram_chunk_index(uint8_t *start, uint8_t *host) >>> +static inline uint64_t ram_chunk_index(const uint8_t *start, >>> + const uint8_t *host) >>> { >>> return ((uintptr_t) host - (uintptr_t) start) >> RDMA_REG_CHUNK_SHIFT; >>> } >>> >>> -static inline uint8_t *ram_chunk_start(RDMALocalBlock *rdma_ram_block, >>> +static inline uint8_t *ram_chunk_start(const RDMALocalBlock *rdma_ram_block, >>> uint64_t i) >>> { >>> return (uint8_t *) (((uintptr_t) rdma_ram_block->local_host_addr) >>> + (i << RDMA_REG_CHUNK_SHIFT)); >>> } >>> >>> -static inline uint8_t *ram_chunk_end(RDMALocalBlock *rdma_ram_block, uint64_t i) >>> +static inline uint8_t *ram_chunk_end(const RDMALocalBlock *rdma_ram_block, >>> + uint64_t i) >>> { >>> uint8_t *result = ram_chunk_start(rdma_ram_block, i) + >>> (1UL << RDMA_REG_CHUNK_SHIFT); >> Isaku, you are sending lots of "little" patches which may or may not be >> properly rebased upon previous patches. >> >> Could you please group your current patch series into a single series with a >> descriptive cover letter along with the previous patches? >> >> If you need create a new patch specifically for RDMA before a previous >> patch as been applied to my tree, then please include the old one into >> the new patch series with a description and a "resend" in the title. >> >> Then I can review them at once apply them all to my tree >> so the maintaner has an easier time. > Okay, will do. Which branch should I watch? > I'm aware of the following repo, but I'm not sure which branch to rebase. > https://github.com/hinesmr/qemu.git There's no need to rebase against github or track my branches. Just use qemu.org master. - Michael