From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2AS-00087I-ON for qemu-devel@nongnu.org; Fri, 20 Sep 2013 10:58:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN2AO-0004UC-77 for qemu-devel@nongnu.org; Fri, 20 Sep 2013 10:58:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2AN-0004U4-UM for qemu-devel@nongnu.org; Fri, 20 Sep 2013 10:58:44 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8KEwgI6018588 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 20 Sep 2013 10:58:42 -0400 Message-ID: <523C62A0.7050206@redhat.com> Date: Fri, 20 Sep 2013 08:58:40 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379678070-14346-1-git-send-email-kwolf@redhat.com> <1379678070-14346-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1379678070-14346-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NNPCgIQ7M45DgnfxI3oT65FP4haELfxCw" Subject: Re: [Qemu-devel] [PATCH 02/17] qapi-types/visit.py: Inheritance for structs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: mreitz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NNPCgIQ7M45DgnfxI3oT65FP4haELfxCw Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/20/2013 05:54 AM, Kevin Wolf wrote: > This introduces a new 'base' key for struct definitions that refers to > another struct type. On the JSON level, the fields of the base type are= > included directly into the same namespace as the fields of the defined > type, like with unions. On the C level, a pointer to a struct of the > base type is included. >=20 > Signed-off-by: Kevin Wolf > --- > docs/qapi-code-gen.txt | 17 +++++++++++++++++ > scripts/qapi-types.py | 4 ++++ > scripts/qapi-visit.py | 18 ++++++++++++++++-- > 3 files changed, 37 insertions(+), 2 deletions(-) > + > +An example BlockdevOptionsGenericCOWFormat object on the wire could us= e > +both fields like this: > + > + { "file": "/some/place/my-image" Missing a comma. > + "backing": "/some/place/my-backing-file" } } Mismatch - too many }. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NNPCgIQ7M45DgnfxI3oT65FP4haELfxCw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSPGKgAAoJEKeha0olJ0NqzkYH/1wrd0kVOl7/EB7BjuUutuws 0SAv3iA341ZiFYRWfgitc+vaC5yrmsj3VaKZMUncNupo37fALMloeZ4VDLXaljMb LmSCRCispEcEVfFhv12NKlAhLyorjtR363uUliGTMWAuQaytQRUaRfKNItMJF0tt dsMSn+xLPzfeIOLoRFn71FDs/QbFTzDu8eVf/bhck5IF++eKkITLi2GB91Mjknwl F9AIDSjdTI+Vv4yMlIvkru1KkLfQ07vsNYRkhTHc/pZayMAq9+gM1acEeQICATpW 1AFP0Z4E5KdqBPv+nzxQePtbOxv+iGgCF8xDclJaML1oSFarpJomdi4EbJgBon0= =pYHX -----END PGP SIGNATURE----- --NNPCgIQ7M45DgnfxI3oT65FP4haELfxCw--