From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2G0-0000qd-78 for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:04:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN2Fq-0006PA-FL for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:04:32 -0400 Received: from mail-ye0-x22f.google.com ([2607:f8b0:4002:c04::22f]:49194) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2Fq-0006P5-BH for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:04:22 -0400 Received: by mail-ye0-f175.google.com with SMTP id q8so160016yen.20 for ; Fri, 20 Sep 2013 08:04:22 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <523C6401.3020509@redhat.com> Date: Fri, 20 Sep 2013 17:04:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1379502855-27759-1-git-send-email-famz@redhat.com> <1379502855-27759-3-git-send-email-famz@redhat.com> <20130919113102.GG22814@stefanha-thinkpad.redhat.com> In-Reply-To: <20130919113102.GG22814@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] vmdk: fix cluster size check for flat extents List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, asias@redhat.com, Fam Zheng , qemu-devel@nongnu.org, stefanha@redhat.com Il 19/09/2013 13:31, Stefan Hajnoczi ha scritto: >> > We use the extent size as cluster size for flat extents (where no L1/L2 >> > table is allocated so it's safe). > Why is the extent size passed as the cluster size parameter? I think it's so that the flat extent doesn't take up too many cache entries. Paolo > The cleaner fix would be to stop passing it as cluster size :).