From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2aS-0001Sy-3A for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:25:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN2aM-0005At-Py for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:25:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2aM-0005An-Dp for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:25:34 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8KFPXgU016713 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 20 Sep 2013 11:25:33 -0400 Message-ID: <523C68ED.8010904@redhat.com> Date: Fri, 20 Sep 2013 09:25:33 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379678070-14346-1-git-send-email-kwolf@redhat.com> <1379678070-14346-4-git-send-email-kwolf@redhat.com> <523C63B9.5040707@redhat.com> <20130920151217.GK2800@dhcp-200-207.str.redhat.com> In-Reply-To: <20130920151217.GK2800@dhcp-200-207.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2VndlKpmDueAjJS2ifC63fVMHJLN9Ci2l" Subject: Re: [Qemu-devel] [PATCH 03/17] blockdev: Introduce DriveInfo.enable_auto_del List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: mreitz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2VndlKpmDueAjJS2ifC63fVMHJLN9Ci2l Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/20/2013 09:12 AM, Kevin Wolf wrote: > Am 20.09.2013 um 17:03 hat Eric Blake geschrieben: >> On 09/20/2013 05:54 AM, Kevin Wolf wrote: >>> BlockDriverStates shouldn't be affected by an unplugged guest device,= >>> except if created with the legacy -drive command line option or the >>> drive_add HMP command. >>> >>> Make the automatic deletion as well as cancelling of jobs conditional= on >>> an enable_auto_del boolean that is only set in drive_init(). >>> >>> Signed-off-by: Kevin Wolf >>> --- >> >>> +++ b/include/sysemu/blockdev.h >>> @@ -37,6 +37,7 @@ struct DriveInfo { >>> int bus; >>> int unit; >>> int auto_del; /* see blockdev_mark_auto_del() */ >>> + bool enable_auto_del; /* Only for legacy drive_init() */ >> >> auto_del is 0-initialized, and only ever assigned to 1. Should it als= o >> be bool? >=20 > Probably. A lot of qemu code uses int for boolean values. I'm trying to= > get rid of them in the block layer in the long run, but so far I haven'= t > aggressively converted fields that I don't touch otherwise. At any rate, that's an independent question; I forgot to mention: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2VndlKpmDueAjJS2ifC63fVMHJLN9Ci2l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSPGjtAAoJEKeha0olJ0NqymYH/3rPr2b/jJhQTrv6lXv49IJ1 3LE/SPDbxpLDSdWSBkzbQKdN7YWCjK5mwa+qSKvL+wZwqV7A5+RQz48vO8plax56 3HP4TMgQMZ6xwj/uxJNIo5cYLiyhToGn+buateRomdiUrPEVsNT81XoAShL1imL7 YAmIAGBDghIKrGmoyg3t4eg8f2Aoz+qgaiE2qQdB0zg7K7GVOIDZ8iF6+hf0jUPy dXMezrfszPQBbMKuOirFatQ+2p7s8y6N00ucNJSpNTgtaUpQjk2MbSTBSg4hGMcQ g+KlvKOdk3krDUWnji3Z8bn3cyrQSKzkUOBzJrr3nucPkOUbz3WwQ75Lq2yFHzI= =GNrW -----END PGP SIGNATURE----- --2VndlKpmDueAjJS2ifC63fVMHJLN9Ci2l--