From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN4l9-0006wJ-DH for qemu-devel@nongnu.org; Fri, 20 Sep 2013 13:45:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN4l0-0005iM-G0 for qemu-devel@nongnu.org; Fri, 20 Sep 2013 13:44:51 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:34938) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN4l0-0005i6-2P for qemu-devel@nongnu.org; Fri, 20 Sep 2013 13:44:42 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 20 Sep 2013 13:44:40 -0400 Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 8157BC9005C for ; Fri, 20 Sep 2013 13:44:33 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by b01cxnp23034.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8KHiX1p55378054 for ; Fri, 20 Sep 2013 17:44:33 GMT Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r8KHiXUt001410 for ; Fri, 20 Sep 2013 13:44:33 -0400 Message-ID: <523C8981.9030701@linux.vnet.ibm.com> Date: Fri, 20 Sep 2013 13:44:33 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <5d53d839653bf4fd24d5cb56f6d24d3dc3f8f8a5.1378261891.git.yamahata@private.email.ne.jp> <9683795de456be26be098f36807d1d4da3027cd0.1378261891.git.yamahata@private.email.ne.jp> <5239C03C.3050209@linux.vnet.ibm.com> <20130920165936.GQ16551@valinux.co.jp> In-Reply-To: <20130920165936.GQ16551@valinux.co.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] rdma: simplify qemu_rdma_register_and_get_keys() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: Isaku Yamahata , quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, mrhines@us.ibm.com, pbonzini@redhat.com On 09/20/2013 12:59 PM, Isaku Yamahata wrote: > On Wed, Sep 18, 2013 at 11:01:16AM -0400, Michael R. Hines wrote: >> The value of chunk_end changes based on whether or not the value of >> block->is_ram_block is true of false. > When is block->is_ram_block set to false? > Looking at __qemu_rdma_add_block() and qemu_rdma_init_ram_blocks(), > is_ram_block seems to be always set to true because local->init = false > when __qemu_rdma_add_block() is called. That's correct, but I have other patches (not yet posted) that depend on block->is_ram_block. Please don't delete it =) - Michael