From: Paolo Bonzini <pbonzini@redhat.com>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: qemu-devel@nongnu.org, linaro-kernel@lists.linaro.org,
kvmarm@lists.cs.columbia.edu, patches@linaro.org,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 5/5] hw: arm_gic_kvm: Add KVM VGIC save/restore logic
Date: Fri, 20 Sep 2013 23:09:47 +0200 [thread overview]
Message-ID: <523CB99B.7050700@redhat.com> (raw)
In-Reply-To: <20130920204116.GV7623@lvm>
Il 20/09/2013 22:41, Christoffer Dall ha scritto:
>> > kvm_arm_gic_dist_readr
>> > kvm_arm_gic_dist_writer
>> >
>> > Why not get_reg/set_reg (I was quite surprised to see readr instead of
>> > reader :) and it took me a while to understand the convention)? Or if
>> > the name is too long, s/readr/get/ and s/writer/set/ would be enough to
>> > match the ioctls.
>> >
> r for register, read register, write register...
>
> I thought I'd seen this convention elsewhere, but I may be wrong. If
> you feel really strongly about it, I can rename.
Yeah, there is readb/w/l and writeb/w/l, but I only found readreg when
grepping for readr. So I think get/set would be better.
Paolo
next prev parent reply other threads:[~2013-09-20 21:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 20:10 [Qemu-devel] [PATCH 0/5] Support arm-gic-kvm save/restore Christoffer Dall
2013-08-23 20:10 ` [Qemu-devel] [PATCH 1/5] hw: arm_gic: Fix gic_set_irq handling Christoffer Dall
2013-09-06 13:59 ` Peter Maydell
2013-09-13 6:38 ` Christoffer Dall
2013-08-23 20:10 ` [Qemu-devel] [PATCH 2/5] hw: arm_gic: Introduce GIC_SET_PRIORITY macro Christoffer Dall
2013-08-25 15:37 ` Alexander Graf
2013-09-13 6:47 ` Christoffer Dall
2013-08-23 20:10 ` [Qemu-devel] [PATCH 3/5] hw: arm_gic: Keep track of SGI sources Christoffer Dall
2013-09-06 14:08 ` Peter Maydell
2013-09-13 19:29 ` Christoffer Dall
2013-08-23 20:10 ` [Qemu-devel] [PATCH 4/5] hw: arm_gic: Support setting/getting binary point reg Christoffer Dall
2013-08-23 21:57 ` Andreas Färber
2013-09-06 14:41 ` Peter Maydell
2013-09-14 1:52 ` Christoffer Dall
2013-09-14 9:46 ` Peter Maydell
2013-09-19 19:48 ` Christoffer Dall
2013-09-19 20:03 ` Christoffer Dall
2013-08-23 20:10 ` [Qemu-devel] [PATCH 5/5] hw: arm_gic_kvm: Add KVM VGIC save/restore logic Christoffer Dall
2013-08-25 15:47 ` Alexander Graf
2013-09-06 14:57 ` Paolo Bonzini
2013-09-20 20:41 ` Christoffer Dall
2013-09-20 21:09 ` Paolo Bonzini [this message]
2013-09-20 21:23 ` Christoffer Dall
2013-09-20 20:39 ` Christoffer Dall
2013-09-06 15:13 ` Peter Maydell
2013-09-20 19:50 ` Christoffer Dall
2013-09-20 21:22 ` Peter Maydell
2013-09-20 21:46 ` Christoffer Dall
2013-09-21 9:38 ` Peter Maydell
2013-09-23 2:14 ` Christoffer Dall
2013-09-23 12:02 ` Peter Maydell
2013-09-23 15:30 ` Christoffer Dall
2013-08-25 15:48 ` [Qemu-devel] [PATCH 0/5] Support arm-gic-kvm save/restore Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523CB99B.7050700@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=christoffer.dall@linaro.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linaro-kernel@lists.linaro.org \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).