From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN7xR-00022Q-Ar for qemu-devel@nongnu.org; Fri, 20 Sep 2013 17:09:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN7xG-00061F-Bt for qemu-devel@nongnu.org; Fri, 20 Sep 2013 17:09:45 -0400 Received: from mail-ee0-x236.google.com ([2a00:1450:4013:c00::236]:65293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN7xG-000615-4n for qemu-devel@nongnu.org; Fri, 20 Sep 2013 17:09:34 -0400 Received: by mail-ee0-f54.google.com with SMTP id e53so501681eek.41 for ; Fri, 20 Sep 2013 14:09:33 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <523CB99B.7050700@redhat.com> Date: Fri, 20 Sep 2013 23:09:47 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377288624-7418-1-git-send-email-christoffer.dall@linaro.org> <1377288624-7418-6-git-send-email-christoffer.dall@linaro.org> <5229ED41.2050501@redhat.com> <20130920204116.GV7623@lvm> In-Reply-To: <20130920204116.GV7623@lvm> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/5] hw: arm_gic_kvm: Add KVM VGIC save/restore logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoffer Dall Cc: qemu-devel@nongnu.org, linaro-kernel@lists.linaro.org, kvmarm@lists.cs.columbia.edu, patches@linaro.org, Alexander Graf Il 20/09/2013 22:41, Christoffer Dall ha scritto: >> > kvm_arm_gic_dist_readr >> > kvm_arm_gic_dist_writer >> > >> > Why not get_reg/set_reg (I was quite surprised to see readr instead of >> > reader :) and it took me a while to understand the convention)? Or if >> > the name is too long, s/readr/get/ and s/writer/set/ would be enough to >> > match the ioctls. >> > > r for register, read register, write register... > > I thought I'd seen this convention elsewhere, but I may be wrong. If > you feel really strongly about it, I can rename. Yeah, there is readb/w/l and writeb/w/l, but I only found readreg when grepping for readr. So I think get/set would be better. Paolo