From: Brad Smith <brad@comstyle.com>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes
Date: Fri, 20 Sep 2013 18:43:41 -0400 [thread overview]
Message-ID: <523CCF9D.1090002@comstyle.com> (raw)
In-Reply-To: <20130919185352.0000135e@unknown>
On 19/09/13 12:53 PM, Sebastian Herbszt wrote:
> Brad Smith wrote:
>> On 20/01/13 1:12 PM, David Woodhouse wrote:
>>> The PCI Firmware Specification apparently requires that the PCI Data
>>> Structure be DWORD-aligned. The implementation in OVMF also requires
>>> this, so vgabios ROMs don't work there. With this fixed, I can now
>>> initialise the VGA ROM from EFI, and EFI can display using INT 10h
>>> services.
>>>
>>> --- vgabios-0.6c/vgabios.c.orig 2013-01-20 11:33:36.138548472
>>> -0600 +++ vgabios-0.6c/vgabios.c 2013-01-20 11:36:26.060270163
>>> -0600 @@ -204,6 +204,7 @@ vgabios_website:
>>> .byte 0x00
>>>
>>> #ifdef PCIBIOS
>>> +.align 4 // DWORD alignment required by PCI Firmware Specification
>>> vgabios_pci_data:
>>> .ascii "PCIR"
>>> #ifdef CIRRUS
>>
>> We have had this in the OpenBSD port of QEMU for awhile now. Is it
>> possible to have this reviewed and commited?
>
> This change was commited to upstream vgabios back in February [1].
But that has not resulted in it being brought into QEMU.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
next prev parent reply other threads:[~2013-09-20 22:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 16:53 [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes Sebastian Herbszt
2013-09-20 22:43 ` Brad Smith [this message]
2013-09-21 16:38 ` Sebastian Herbszt
2013-09-25 23:24 ` Brad Smith
2013-10-09 1:56 ` Brad Smith
2013-10-09 15:18 ` Andreas Färber
2013-10-10 19:17 ` Sebastian Herbszt
2013-10-11 6:31 ` Gerd Hoffmann
2013-11-24 20:35 ` Brad Smith
2013-11-25 7:02 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2013-01-20 18:12 David Woodhouse
2013-09-13 0:05 ` Brad Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523CCF9D.1090002@comstyle.com \
--to=brad@comstyle.com \
--cc=herbszt@gmx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).