From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59164)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1VN9SJ-0002eN-Ed
	for qemu-devel@nongnu.org; Fri, 20 Sep 2013 18:45:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1VN9SI-0005ok-K6
	for qemu-devel@nongnu.org; Fri, 20 Sep 2013 18:45:43 -0400
Received: from speedy.comstyle.com ([2001:470:1d:8c::2]:26871
	helo=mail.comstyle.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1VN9SI-0005kE-FV
	for qemu-devel@nongnu.org; Fri, 20 Sep 2013 18:45:42 -0400
Message-ID: <523CCF9D.1090002@comstyle.com>
Date: Fri, 20 Sep 2013 18:43:41 -0400
From: Brad Smith <brad@comstyle.com>
MIME-Version: 1.0
References: <20130919185352.0000135e@unknown>
In-Reply-To: <20130919185352.0000135e@unknown>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: qemu-devel@nongnu.org

On 19/09/13 12:53 PM, Sebastian Herbszt wrote:
> Brad Smith wrote:
>> On 20/01/13 1:12 PM, David Woodhouse wrote:
>>> The PCI Firmware Specification apparently requires that the PCI Data
>>> Structure be DWORD-aligned. The implementation in OVMF also requires
>>> this, so vgabios ROMs don't work there. With this fixed, I can now
>>> initialise the VGA ROM from EFI, and EFI can display using INT 10h
>>> services.
>>>
>>> --- vgabios-0.6c/vgabios.c.orig	2013-01-20 11:33:36.138548472
>>> -0600 +++ vgabios-0.6c/vgabios.c	2013-01-20 11:36:26.060270163
>>> -0600 @@ -204,6 +204,7 @@ vgabios_website:
>>>    .byte	0x00
>>>
>>>    #ifdef PCIBIOS
>>> +.align 4 // DWORD alignment required by PCI Firmware Specification
>>>    vgabios_pci_data:
>>>    .ascii "PCIR"
>>>    #ifdef CIRRUS
>>
>> We have had this in the OpenBSD port of QEMU for awhile now. Is it
>> possible to have this reviewed and commited?
>
> This change was commited to upstream vgabios back in February [1].

But that has not resulted in it being brought into QEMU.


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.