From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VNszP-0007Bo-C9 for qemu-devel@nongnu.org; Sun, 22 Sep 2013 19:23:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VNszG-0005RH-EH for qemu-devel@nongnu.org; Sun, 22 Sep 2013 19:22:55 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:58147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VNszF-0005R8-On for qemu-devel@nongnu.org; Sun, 22 Sep 2013 19:22:46 -0400 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 23 Sep 2013 04:52:40 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 6705CE0040 for ; Mon, 23 Sep 2013 04:53:40 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8MNOsgZ36896786 for ; Mon, 23 Sep 2013 04:54:55 +0530 Received: from d28av02.in.ibm.com (localhost [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r8MNMa63013046 for ; Mon, 23 Sep 2013 04:52:36 +0530 Message-ID: <523F7BBC.4010707@linux.vnet.ibm.com> Date: Mon, 23 Sep 2013 07:22:36 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1379838614-23890-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1379838614-23890-2-git-send-email-xiawenc@linux.vnet.ibm.com> <523F54D4.4030103@msgid.tls.msk.ru> In-Reply-To: <523F54D4.4030103@msgid.tls.msk.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 1/2] tests: build the helper program in main build process List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@gmail.com On 09/23/2013 04:36 AM, Michael Tokarev wrote: > 22.09.2013 12:30, Wenchao Xia пишет: >> This is a quick way to update helper program when qemu main code >> is changed or built, instead of adding new Makefile under >> test/qemu-iotest. > > Why? > > [] I think it is a bit overkill to have a new Makefile for one single .c file. If more file comes, we can write Makefile at that time. >> +# Build the help program automatically >> + >> +all: $(QEMU_IOTESTS_HELPERS-y) >> > > This appears to be somewhat awkward way (to do something which I > clearly don't see). > > First, it is not clear why this iotest helper should be built > by default when we hasn't been asked to perform the tests. Usually we may: 1 configure and make. 2 goto tests/qemu-iotests, ./check. It may encounter an error since build of the helper was not triggered. > > Second, it apparently does not achieve the (unknown) goal > anyway. At least the patch does not do what the commit > coment says. Commit says that the helper gets updated when > qemu main code is changed or built (which is main code?). > But when I build, say, subdir-x86_64-softmmu, which is > definitely some "main" code, the helper isn't being built... > Main code may refer to the codes other than ./tests, the commit message is not accurate, I think it should be "build the helper by default". > Count me confused... :) > > /mjt >