From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO221-0004Bp-2t for qemu-devel@nongnu.org; Mon, 23 Sep 2013 05:02:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VO21s-0002eV-7m for qemu-devel@nongnu.org; Mon, 23 Sep 2013 05:02:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO21s-0002eM-0J for qemu-devel@nongnu.org; Mon, 23 Sep 2013 05:02:04 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8N922pU031063 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 23 Sep 2013 05:02:02 -0400 Message-ID: <52400387.1070103@redhat.com> Date: Mon, 23 Sep 2013 11:01:59 +0200 From: Max Reitz MIME-Version: 1.0 References: <1379678070-14346-1-git-send-email-kwolf@redhat.com> <1379678070-14346-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1379678070-14346-6-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/17] blockdev: Separate ID generation from DriveInfo creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com On 2013-09-20 13:54, Kevin Wolf wrote: > blockdev-add shouldn't automatically generate IDs, but will keep most of > the DriveInfo creation code. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 32 +++++++++++++++++--------------- > include/qemu/option.h | 1 + > util/qemu-option.c | 6 ++++++ > 3 files changed, 24 insertions(+), 15 deletions(-) Reviewed-by: Max Reitz