From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO24G-00067l-6O for qemu-devel@nongnu.org; Mon, 23 Sep 2013 05:04:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VO24A-00030q-71 for qemu-devel@nongnu.org; Mon, 23 Sep 2013 05:04:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO249-00030X-W7 for qemu-devel@nongnu.org; Mon, 23 Sep 2013 05:04:26 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8N94Pp4030991 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 23 Sep 2013 05:04:25 -0400 Message-ID: <52400416.90904@redhat.com> Date: Mon, 23 Sep 2013 11:04:22 +0200 From: Max Reitz MIME-Version: 1.0 References: <1379678070-14346-1-git-send-email-kwolf@redhat.com> <1379678070-14346-13-git-send-email-kwolf@redhat.com> In-Reply-To: <1379678070-14346-13-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/17] blockdev: Move virtio-blk device creation to drive_init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com On 2013-09-20 13:54, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > blockdev.c | 54 +++++++++++++++++++++++++++--------------------------- > 1 file changed, 27 insertions(+), 27 deletions(-) Aside from return NULL instead of goto fail: Reviewed-by: Max Reitz