From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO6OW-0001b1-N2 for qemu-devel@nongnu.org; Mon, 23 Sep 2013 09:41:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VO6ON-0008BY-5t for qemu-devel@nongnu.org; Mon, 23 Sep 2013 09:41:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO6OM-0008BH-UR for qemu-devel@nongnu.org; Mon, 23 Sep 2013 09:41:35 -0400 Message-ID: <524045A2.2000201@redhat.com> Date: Mon, 23 Sep 2013 15:44:02 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1379857006-17451-1-git-send-email-mst@redhat.com> <1379857006-17451-13-git-send-email-mst@redhat.com> <524035D9.5050108@redhat.com> <20130923133910.GC1278@redhat.com> In-Reply-To: <20130923133910.GC1278@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 12/23] acpi: add rules to compile ASL source List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Paolo Bonzini , qemu-devel@nongnu.org, Anthony Liguori , afaerber@suse.de On 09/23/13 15:39, Michael S. Tsirkin wrote: > On Mon, Sep 23, 2013 at 02:36:41PM +0200, Paolo Bonzini wrote: >> Il 22/09/2013 15:37, Michael S. Tsirkin ha scritto: >>> Detect presence of IASL compiler and use it >>> to process ASL source. If not there, use pre-compiled >>> files in-tree. Add script to update the in-tree files. >>> >>> Note: distros are known to silently update iasl >>> so detect correct iasl flags for the installed version on each run as >>> opposed to at configure time. >> >> This is not any different from a C compiler, which is likely updated >> much much more often than iasl. > > Yes but it's not a theoretical issue: > we did catch iasl changing flags semantics on the fly, once. > > I think compilers don't do this as a norm :) (Fully tangentially... gcc and clang emit warnings for a new set of code constructs every other week. When combined with -Werror, it's super annoying; valid and intentional code can stop to build unexpectedly. Good thing we have --disable-werror for this.) Laszlo