From: Eric Blake <eblake@redhat.com>
To: Mark Wu <wudxw@linux.vnet.ibm.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
Qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'
Date: Mon, 23 Sep 2013 07:57:54 -0600 [thread overview]
Message-ID: <524048E2.6040408@redhat.com> (raw)
In-Reply-To: <1379832654-21722-1-git-send-email-wudxw@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]
On 09/22/2013 12:50 AM, Mark Wu wrote:
> Now we have several qemu-ga commands not returning response on success.
> It has been documented in qga/qapi-schema.json already. This patch exposes
> the 'success-response' flag by extending 'guest-info' command. With this
> change, the clients can handle the command response more flexibly.
>
> Changes:
> v2: add the notation 'since 1.7' to the option 'success-response'
> (per Eric Blake's comments)
Typically, the patch changelog should be placed...
>
> Signed-off-by: Mark Wu <wudxw@linux.vnet.ibm.com>
> ---
...after the --- separator (see
http://wiki.qemu.org/Contribute/SubmitAPatch for more hints).
> +++ b/qga/qapi-schema.json
> @@ -141,10 +141,13 @@
> #
> # @enabled: whether command is currently enabled by guest admin
> #
> +# @success-response: whether command returns a response on success
> +# and only available since 1.7
More typically, this is written:
@success-response: whether command returns a response on
success (since 1.7)
but as we don't parse the documentation, it doesn't hurt as written.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-09-23 13:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 6:50 [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response' Mark Wu
2013-09-23 12:32 ` Luiz Capitulino
2013-09-23 13:57 ` Eric Blake [this message]
2013-09-24 19:00 ` Michael Roth
2013-09-24 19:13 ` Eric Blake
2013-09-24 21:07 ` Michael Roth
2013-09-25 0:34 ` Luiz Capitulino
2013-09-25 12:30 ` Mark Wu
-- strict thread matches above, loose matches on Subject: below --
2013-09-18 7:23 Mark Wu
2013-09-18 12:45 ` Luiz Capitulino
2013-09-18 12:59 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524048E2.6040408@redhat.com \
--to=eblake@redhat.com \
--cc=Qemu-devel@nongnu.org \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=wudxw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).