From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO6eK-0004eR-6g for Qemu-devel@nongnu.org; Mon, 23 Sep 2013 09:58:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VO6eD-0004ww-Ni for Qemu-devel@nongnu.org; Mon, 23 Sep 2013 09:58:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO6eD-0004wq-EM for Qemu-devel@nongnu.org; Mon, 23 Sep 2013 09:57:57 -0400 Message-ID: <524048E2.6040408@redhat.com> Date: Mon, 23 Sep 2013 07:57:54 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379832654-21722-1-git-send-email-wudxw@linux.vnet.ibm.com> In-Reply-To: <1379832654-21722-1-git-send-email-wudxw@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jcBohJNq5wn7iwQjMeg7h4cLjwwchNmH7" Subject: Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Wu Cc: Michael Roth , Qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jcBohJNq5wn7iwQjMeg7h4cLjwwchNmH7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/22/2013 12:50 AM, Mark Wu wrote: > Now we have several qemu-ga commands not returning response on success.= > It has been documented in qga/qapi-schema.json already. This patch expo= ses > the 'success-response' flag by extending 'guest-info' command. With thi= s > change, the clients can handle the command response more flexibly. >=20 > Changes: > v2: add the notation 'since 1.7' to the option 'success-response' > (per Eric Blake's comments) Typically, the patch changelog should be placed... >=20 > Signed-off-by: Mark Wu > --- =2E..after the --- separator (see http://wiki.qemu.org/Contribute/SubmitAPatch for more hints). > +++ b/qga/qapi-schema.json > @@ -141,10 +141,13 @@ > # > # @enabled: whether command is currently enabled by guest admin > # > +# @success-response: whether command returns a response on success > +# and only available since 1.7 More typically, this is written: @success-response: whether command returns a response on success (since 1.7) but as we don't parse the documentation, it doesn't hurt as written. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jcBohJNq5wn7iwQjMeg7h4cLjwwchNmH7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSQEjiAAoJEKeha0olJ0NqmhUIAK1KTMThOXMpK/s7WbTMWdkC x7SWr3bZUlJa4plf7AddN4UNDmzKOMoBAYxyA1sd3qrDm12aLDR86t+AShmZYavs aOrXHOPSPQNR7/8RBmNBWf1H2NmgdjIYKBKErHvDzUKmS/md5V+pskWz0Y0Rl/b0 E8+7vCQrYFDOGA/ukYifXTpRL6nBleCdXtZzq9AkJ8NOY1JWNOLW+qifGSeJf1/F iMOF2dXO0ZtdYQHZNoxWqHevTaOzw+NJgYmH+75tmy4KsPzfF27stL/73ybe6Y70 JyLYRw009iRU/FEtHFNLcCsFhMpvgHN2aBiYUYS2Mzg7oIBrNpnPbmnSOKkQcJU= =p++4 -----END PGP SIGNATURE----- --jcBohJNq5wn7iwQjMeg7h4cLjwwchNmH7--