From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO8Xy-0005qP-4S for qemu-devel@nongnu.org; Mon, 23 Sep 2013 11:59:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VO8Xt-0007Zy-IQ for qemu-devel@nongnu.org; Mon, 23 Sep 2013 11:59:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO8Xt-0007Zu-8U for qemu-devel@nongnu.org; Mon, 23 Sep 2013 11:59:33 -0400 Message-ID: <5240655F.6080301@redhat.com> Date: Mon, 23 Sep 2013 09:59:27 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379937171-32128-1-git-send-email-benoit@irqsave.net> <1379937171-32128-2-git-send-email-benoit@irqsave.net> In-Reply-To: <1379937171-32128-2-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mwlcusUI7vFCfIPaUrsiDNLmDfCtDQnGk" Subject: Re: [Qemu-devel] [PATCH V2] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mwlcusUI7vFCfIPaUrsiDNLmDfCtDQnGk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/23/2013 05:52 AM, Beno=C3=AEt Canet wrote: > Some drivers will have driver specifics options but no filename. > This new bool allow the block layer to treat them correctly. >=20 > The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filen= ame and > not having .bdrv_open. >=20 > The first exception to this rule will be the quorum driver. >=20 > Signed-off-by: Benoit Canet > --- > +++ b/include/block/block_int.h > @@ -73,6 +73,7 @@ struct BlockDriver { > /* Any driver implementing this callback is expected to be able to= handle > * NULL file names in its .bdrv_open() implementation */ > void (*bdrv_parse_filename)(const char *filename, QDict *options, = Error **errp); > + bool bdrv_needs_filename; Please use inline comments documenting this field's use. > =20 > /* For handling image reopen for split or non-split files */ > int (*bdrv_reopen_prepare)(BDRVReopenState *reopen_state, >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mwlcusUI7vFCfIPaUrsiDNLmDfCtDQnGk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSQGVfAAoJEKeha0olJ0NqWkkH/0ip5NQOvJq4hMWyWpBlrCcY ErZdPsBpfvWEyvZw5UBkim24ATpFWZKIcriAk2ybrrqZ+FTjXNXwfPq/9HQl2FFq asd3Gw78aJ+mO20URmGpSh3F1Vmy8VQPZoRtdCLYdxGa6FrPUGs7YRCAvM9pIlAp qzDWKmVTlKePz4FX3KzeADtoTrXP7q+LJTaQf9pl4YztOVJFipkIqusGCAaKYh/r 8Q4SQwWF9NcxhezjNPz3kkCO+R8EkM3yHtBg1H2C72gqh7iL0k3ldoSRTMwmKn5M kHkiYzv5swwz4qVDiZctn1bYczrwjZcpxmXcY5OKuONIDRLElMxth9xI810DQZA= =qMw0 -----END PGP SIGNATURE----- --mwlcusUI7vFCfIPaUrsiDNLmDfCtDQnGk--