From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOJBQ-00008s-0h for qemu-devel@nongnu.org; Mon, 23 Sep 2013 23:21:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOJBH-0003wA-3K for qemu-devel@nongnu.org; Mon, 23 Sep 2013 23:21:03 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:49381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOJBG-0003w2-Ch for qemu-devel@nongnu.org; Mon, 23 Sep 2013 23:20:55 -0400 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 Sep 2013 08:50:49 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 5FA2A125803F for ; Tue, 24 Sep 2013 08:50:57 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8O3KgDo45744286 for ; Tue, 24 Sep 2013 08:50:44 +0530 Received: from d28av04.in.ibm.com (localhost [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r8O3Ki9w003229 for ; Tue, 24 Sep 2013 08:50:44 +0530 Message-ID: <524104FE.1080503@linux.vnet.ibm.com> Date: Tue, 24 Sep 2013 11:20:30 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1379838614-23890-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1379838614-23890-2-git-send-email-xiawenc@linux.vnet.ibm.com> <523F54D4.4030103@msgid.tls.msk.ru> <523F7BBC.4010707@linux.vnet.ibm.com> In-Reply-To: <523F7BBC.4010707@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 1/2] tests: build the helper program in main build process List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@gmail.com 于 2013/9/23 7:22, Wenchao Xia 写道: > On 09/23/2013 04:36 AM, Michael Tokarev wrote: >> 22.09.2013 12:30, Wenchao Xia пишет: >>> This is a quick way to update helper program when qemu main code >>> is changed or built, instead of adding new Makefile under >>> test/qemu-iotest. >> >> Why? >> >> [] > I think it is a bit overkill to have a new Makefile for one single > .c file. If more > file comes, we can write Makefile at that time. > > >>> +# Build the help program automatically >>> + >>> +all: $(QEMU_IOTESTS_HELPERS-y) >>> >> >> This appears to be somewhat awkward way (to do something which I >> clearly don't see). >> >> First, it is not clear why this iotest helper should be built >> by default when we hasn't been asked to perform the tests. > Usually we may: > 1 configure and make. > 2 goto tests/qemu-iotests, ./check. > > It may encounter an error since build of the helper was not triggered. > >> >> Second, it apparently does not achieve the (unknown) goal >> anyway. At least the patch does not do what the commit >> coment says. Commit says that the helper gets updated when >> qemu main code is changed or built (which is main code?). >> But when I build, say, subdir-x86_64-softmmu, which is >> definitely some "main" code, the helper isn't being built... >> > Main code may refer to the codes other than ./tests, the commit > message is not accurate, I think it should be "build the helper by > default". > >> Count me confused... :) >> >> /mjt >> > > Are you OK with this method? To add a callable Makefile by tests/qemu-iotests/check, configure, variable may be needed to work on out of tree build case, so I try to avoid that. This patches simply build it in default make process. If yes I will respin a version with better commit message.