From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOJQw-0002Ug-Fr for qemu-devel@nongnu.org; Mon, 23 Sep 2013 23:37:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOJQn-00086Z-9b for qemu-devel@nongnu.org; Mon, 23 Sep 2013 23:37:06 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:53212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOJQm-00082B-Hj for qemu-devel@nongnu.org; Mon, 23 Sep 2013 23:36:57 -0400 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 Sep 2013 09:06:46 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id E5704E0058 for ; Tue, 24 Sep 2013 09:07:47 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8O3cwO037027956 for ; Tue, 24 Sep 2013 09:08:59 +0530 Received: from d28av04.in.ibm.com (localhost [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r8O3ahC3012082 for ; Tue, 24 Sep 2013 09:06:44 +0530 Message-ID: <524108BD.9000700@linux.vnet.ibm.com> Date: Tue, 24 Sep 2013 11:36:29 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1378695482-29805-1-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1378695482-29805-1-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V3 0/7] qcow2: rollback the modification on fail in snapshot creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, pbonzini@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org, stefanha@gmail.com ÓÚ 2013/9/9 10:57, Wenchao Xia дµÀ: > V2: > 1: all fail case will goto fail section. > 2: add the goto code. > v3: > Address Stefan's comments: > 2: don't goto fail after allocation failure. > 3: use sn->l1size correctly in qcow2_free_cluster(). > 4-7: add test case to verify the error paths. > Other: > 1: new patch fix a existing bug, which will be exposed in error path test. > > > Wenchao Xia (7): > 1 qcow2: restore nb_snapshots when fail in snapshot creation > 2 qcow2: free allocated cluster on fail in qcow2_write_snapshots() > 3 qcow2: cancel the modification on fail in qcow2_snapshot_create() > 4 blkdebug: add debug events for snapshot > 5 qcow2: use debug events for snapshot > 6 qcow2: print message for error path in snapshot creation > 7 qemu-iotests: add test for qcow2 snapshot > > block/blkdebug.c | 4 + > block/qcow2-snapshot.c | 80 ++++++++++++++-- > include/block/block.h | 4 + > tests/qemu-iotests/063 | 229 ++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/063.out | 37 +++++++ > tests/qemu-iotests/group | 1 + > 6 files changed, 348 insertions(+), 7 deletions(-) > create mode 100755 tests/qemu-iotests/063 > create mode 100644 tests/qemu-iotests/063.out > Hello, any comments for it?