From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33625)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VONqm-0002n8-LS
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 04:20:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VONqf-0004FP-1r
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 04:20:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54324)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VONqe-0004FL-PC
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 04:19:56 -0400
Message-ID: <5241492F.7030701@redhat.com>
Date: Tue, 24 Sep 2013 10:11:27 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1379842791-3776-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1379842791-3776-3-git-send-email-xiawenc@linux.vnet.ibm.com>
	<52401735.7090503@redhat.com> <5240FF65.2090909@linux.vnet.ibm.com>
In-Reply-To: <5240FF65.2090909@linux.vnet.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V2 2/4] qemu-nbd: support internal snapshot
	export
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org

Il 24/09/2013 04:56, Wenchao Xia ha scritto:
> =E4=BA=8E 2013/9/23 18:25, Paolo Bonzini =E5=86=99=E9=81=93:
>> Il 22/09/2013 11:39, Wenchao Xia ha scritto:
>>> Now it is possible to directly export an internal snapshot, which
>>> can be used to probe the snapshot's contents without qemu-img
>>> convert.
>>>
>>> Signed-off-by: Wenchao Xia<xiawenc@linux.vnet.ibm.com>
>>> ---
>>>   qemu-nbd.c |   54
>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>>   1 files changed, 53 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/qemu-nbd.c b/qemu-nbd.c
>>> index c26c98e..e450d04 100644
>>> --- a/qemu-nbd.c
>>> +++ b/qemu-nbd.c
>>> @@ -20,6 +20,7 @@
>>>   #include "block/block.h"
>>>   #include "block/nbd.h"
>>>   #include "qemu/main-loop.h"
>>> +#include "block/snapshot.h"
>>>
>>>   #include<stdarg.h>
>>>   #include<stdio.h>
>>> @@ -304,6 +305,23 @@ static void nbd_accept(void *opaque)
>>>       }
>>>   }
>>>
>>> +#define SNAPSHOT_OPT_ID         "id"
>>> +#define SNAPSHOT_OPT_NAME       "name"
>>> +
>>> +static QEMUOptionParameter snapshot_options[] =3D {
>>> +    {
>>> +        .name =3D SNAPSHOT_OPT_ID,
>>> +        .type =3D OPT_STRING,
>>> +        .help =3D "snapshot id"
>>> +    },
>>> +    {
>>> +        .name =3D SNAPSHOT_OPT_NAME,
>>> +        .type =3D OPT_STRING,
>>> +        .help =3D "snapshot name"
>>> +    },
>>> +    { NULL }
>>> +};
>> I think whatever mechanism you use here to pick a snapshot id or name
>> should be implemented in qemu-img too.
> qemu-img already pick up snapshot by mixed id and name, do you like to
> add a new
> interface like the above(Keep old interface untouched for compatiablity=
)?

Yes, please.  And also implement the "mixed" method here.

>> Also, I think QEMUOptionParameter is being phased out.
>>
> Is QemuOptsList the recommanded method?

Yes.

Paolo