From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39341)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VOQ1F-00067k-7D
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 06:39:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VOQ16-0005DM-Q8
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 06:39:01 -0400
Received: from mail-qa0-x236.google.com ([2607:f8b0:400d:c00::236]:52828)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VOQ16-0005DH-LM
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 06:38:52 -0400
Received: by mail-qa0-f54.google.com with SMTP id bv4so2316773qab.6
	for <qemu-devel@nongnu.org>; Tue, 24 Sep 2013 03:38:52 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52416BC9.5000403@redhat.com>
Date: Tue, 24 Sep 2013 12:39:05 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1379678070-14346-1-git-send-email-kwolf@redhat.com>
	<1379678070-14346-5-git-send-email-kwolf@redhat.com>
In-Reply-To: <1379678070-14346-5-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: mreitz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com

Il 20/09/2013 13:54, Kevin Wolf ha scritto:
> +     * For now, simply forbidding the combination for all drivers will do. */
> +    if (options->has_aio && options->aio == BLOCKDEV_A_I_O_OPTIONS_NATIVE) {

Let's call it BlockdevAioOptions instead?

Paolo


> +        bool direct = options->cache->has_direct && options->cache->direct;
> +        if (!options->has_cache && !direct) {
> +            error_setg(errp, "aio=native requires cache.direct=true");