From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39817)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VOQ3U-0007Ip-UC
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 06:41:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VOQ3M-0005v9-EB
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 06:41:20 -0400
Received: from mail-qa0-x22e.google.com ([2607:f8b0:400d:c00::22e]:60895)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VOQ3M-0005v2-AB
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 06:41:12 -0400
Received: by mail-qa0-f46.google.com with SMTP id j7so2321161qaq.12
	for <qemu-devel@nongnu.org>; Tue, 24 Sep 2013 03:41:11 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52416C56.5070809@redhat.com>
Date: Tue, 24 Sep 2013 12:41:26 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1379678070-14346-1-git-send-email-kwolf@redhat.com>
	<1379678070-14346-5-git-send-email-kwolf@redhat.com>
	<20130920140109.GB6794@irqsave.net>
In-Reply-To: <20130920140109.GB6794@irqsave.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Beno=EEt_Canet?= <benoit.canet@irqsave.net>
Cc: Kevin Wolf <kwolf@redhat.com>, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com

Il 20/09/2013 16:01, Benoît Canet ha scritto:
>> > +    if (error_is_set(&local_err)) {
>> > +        error_propagate(errp, local_err);
>> > +        goto fail;
> There is nothing to execute between error_propagate and fail: maybe we could
> get rid of the goto.

Or perhaps of the "else".

Paolo

>> > +    } else {
>> > +        dinfo = blockdev_init(opts, IF_NONE);
>> > +        if (!dinfo) {
>> > +            error_setg(errp, "Could not open image");
>> > +            goto fail;
> Same.
>> > +        }
>> > +    }