From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59430)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1VORTY-0003Hp-QM
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 08:12:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1VORTS-0002T6-N4
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 08:12:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13319)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1VORTS-0002T1-FF
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 08:12:14 -0400
Message-ID: <52418198.4090709@redhat.com>
Date: Tue, 24 Sep 2013 14:12:08 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1380017641-29820-1-git-send-email-riegamaths@gmail.com>
In-Reply-To: <1380017641-29820-1-git-send-email-riegamaths@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block: use correct filename for error
	report
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dunrong Huang <riegamaths@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

On 2013-09-24 12:14, Dunrong Huang wrote:
> The content filename point to will be erased by qemu_opts_absorb_qdict()
> in raw_open_common() in drv->bdrv_file_open()
>
> So it's better to use bs->filename.
>
> Signed-off-by: Dunrong Huang <riegamaths@gmail.com>
> ---
>   block.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>