From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43771) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOSH0-00066L-Tt for qemu-devel@nongnu.org; Tue, 24 Sep 2013 09:03:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOSGw-00022p-Ex for qemu-devel@nongnu.org; Tue, 24 Sep 2013 09:03:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOSGw-00022T-64 for qemu-devel@nongnu.org; Tue, 24 Sep 2013 09:03:22 -0400 Message-ID: <52418D93.6040606@redhat.com> Date: Tue, 24 Sep 2013 07:03:15 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380025627-32676-1-git-send-email-benoit@irqsave.net> <1380025627-32676-2-git-send-email-benoit@irqsave.net> In-Reply-To: <1380025627-32676-2-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jW7e5tUUXJR6whqvXMl1Uhq5ssbdFvjj4" Subject: Re: [Qemu-devel] [PATCH V3] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jW7e5tUUXJR6whqvXMl1Uhq5ssbdFvjj4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/24/2013 06:27 AM, Beno=C3=AEt Canet wrote: > Some drivers will have driver specifics options but no filename. > This new bool allow the block layer to treat them correctly. >=20 > The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filen= ame and > not having .bdrv_open. >=20 > The first exception to this rule will be the quorum driver. >=20 > Signed-off-by: Benoit Canet > --- > +++ b/include/block/block_int.h > @@ -73,6 +73,11 @@ struct BlockDriver { > /* Any driver implementing this callback is expected to be able to= handle > * NULL file names in its .bdrv_open() implementation */ > void (*bdrv_parse_filename)(const char *filename, QDict *options, = Error **errp); > + /* Drivers not implementing bdrv_parse_filename nor bdrv_open shou= ld have > + * this field set to true excepted the ones only defined by their = childs bs. > + * An example of the last type will be the quorum block driver. Grammar: Drivers not implementing ... set to true, except ones that are defined only by their child's bs. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jW7e5tUUXJR6whqvXMl1Uhq5ssbdFvjj4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSQY2UAAoJEKeha0olJ0NqD5EIAJ9JdFInTiJQaO9DhEJD8R43 WIKnoEkSj0JhFLZpRNdVe2oPvVNL/FwzbaPwbe7PEFGpGj/pcqJIxKGgrmCDS7g6 iQg9PN0M9iK5y1BxLFsSQ+iIOFhVklrzqtu49dXLnU/CDWzrdhjszIJVIIIq2rI0 wjlB+vpGnLhO2SfPXPQ94DqWE6aWQaDnTrYDF2A5IDwv1lDVkViNVH75kV9tpO7D 3zXOgBZ1KTiokwDWME7DmA/3VzhzWnLjzR+Z5R3ZkZc03Bhnglvf2vbNrjLiTs09 pi+V09quubQutUIN9a73Vh5osXxgMaopjIQUR9KNJ8UxTdji7mXJjYV8vJOkad8= =wOzh -----END PGP SIGNATURE----- --jW7e5tUUXJR6whqvXMl1Uhq5ssbdFvjj4--