From: Eric Blake <eblake@redhat.com>
To: "Benoît Canet" <benoit@irqsave.net>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH V4] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.
Date: Tue, 24 Sep 2013 09:21:44 -0600 [thread overview]
Message-ID: <5241AE08.1030400@redhat.com> (raw)
In-Reply-To: <1380035224-7364-2-git-send-email-benoit@irqsave.net>
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
On 09/24/2013 09:07 AM, Benoît Canet wrote:
> Some drivers will have driver specifics options but no filename.
> This new bool allow the block layer to treat them correctly.
>
> The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filename and
> not having .bdrv_open.
>
> The first exception to this rule will be the quorum driver.
>
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
> block.c | 5 +++--
> block/gluster.c | 4 ++++
> block/iscsi.c | 1 +
> block/raw-posix.c | 5 +++++
> block/raw-win32.c | 2 ++
> block/rbd.c | 1 +
> block/sheepdog.c | 3 +++
> include/block/block_int.h | 6 ++++++
> 8 files changed, 25 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-09-24 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 15:07 [Qemu-devel] [PATCH V4] introduce .bdrv_needs_filename Benoît Canet
2013-09-24 15:07 ` [Qemu-devel] [PATCH V4] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers Benoît Canet
2013-09-24 15:21 ` Eric Blake [this message]
2013-09-25 11:25 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5241AE08.1030400@redhat.com \
--to=eblake@redhat.com \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).