From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOUR0-0000FK-LB for qemu-devel@nongnu.org; Tue, 24 Sep 2013 11:21:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOUQv-0005b6-RQ for qemu-devel@nongnu.org; Tue, 24 Sep 2013 11:21:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOUQv-0005Zf-I5 for qemu-devel@nongnu.org; Tue, 24 Sep 2013 11:21:49 -0400 Message-ID: <5241AE08.1030400@redhat.com> Date: Tue, 24 Sep 2013 09:21:44 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380035224-7364-1-git-send-email-benoit@irqsave.net> <1380035224-7364-2-git-send-email-benoit@irqsave.net> In-Reply-To: <1380035224-7364-2-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DqbD6u6ihwpEdAnM6Mchu73iE4BOok6Hq" Subject: Re: [Qemu-devel] [PATCH V4] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DqbD6u6ihwpEdAnM6Mchu73iE4BOok6Hq Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/24/2013 09:07 AM, Beno=C3=AEt Canet wrote: > Some drivers will have driver specifics options but no filename. > This new bool allow the block layer to treat them correctly. >=20 > The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filen= ame and > not having .bdrv_open. >=20 > The first exception to this rule will be the quorum driver. >=20 > Signed-off-by: Benoit Canet > --- > block.c | 5 +++-- > block/gluster.c | 4 ++++ > block/iscsi.c | 1 + > block/raw-posix.c | 5 +++++ > block/raw-win32.c | 2 ++ > block/rbd.c | 1 + > block/sheepdog.c | 3 +++ > include/block/block_int.h | 6 ++++++ > 8 files changed, 25 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DqbD6u6ihwpEdAnM6Mchu73iE4BOok6Hq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSQa4IAAoJEKeha0olJ0Nq9KUIAK0rdIXaPMg8FzB5e/egT47x 6d8NI27x5Q1J6sHreR6pq8nQSG45nx462Tt3eQDOox+o74yba2b58lx7dWAb81mK jJJrYMEg0MClYwqMlIMm9v4+1csaghl28vABh3IvfjlXENdLqyaI0mvFdabdod5d 0//SOLj0PpCRuCDEl1UOWahoiWOEdyPs2idYlNP6UJbwdx+jN8OwQl3qWLdbSRNg KvApHOmF+bXoysVdexE+ib1Svg6n0oINC+vio9HzoJXgQenuE7rJd3CJ1R8bo/58 8qdV5eU8ltLT2Mt0EYxkW8m8ND4JTmRmrh5mxZl52fwdkC2DrBQVmrC3KMIa1qM= =0TD7 -----END PGP SIGNATURE----- --DqbD6u6ihwpEdAnM6Mchu73iE4BOok6Hq--