From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
To: Frank <frank.yangjie@gmail.com>
Cc: Isaku Yamahata <yamahata@private.email.ne.jp>,
qemu-devel@nongnu.org, Michael R Hines <mrhines@us.ibm.com>,
qemu-stable@nongnu.org, lilei@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak InetSocketAddress
Date: Tue, 24 Sep 2013 13:53:43 -0400 [thread overview]
Message-ID: <5241D1A7.8090008@linux.vnet.ibm.com> (raw)
In-Reply-To: <5231C6FC.3060506@gmail.com>
On 09/12/2013 09:51 AM, Frank wrote:
> It is allocated by g_new0() in inet_parse(), so needs to be freed in qemu_rdma_data_init().
>
> From d7a8d1aad11fbe9af389cf9dd6cee14cc3249b1f Mon Sep 17 00:00:00 2001
> From: Frank Yang <frank.yangjie@gmail.com>
> Date: Thu, 12 Sep 2013 21:37:56 +0800
> Subject: [PATCH] rdma: memory leak InetSocketAddress
>
> Signed-off-by: Frank Yang <frank.yangjie@gmail.com>
> ---
> migration-rdma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/migration-rdma.c b/migration-rdma.c
> index 05a155b..bcbe2d2 100644
> --- a/migration-rdma.c
> +++ b/migration-rdma.c
> @@ -2512,6 +2512,7 @@ static void *qemu_rdma_data_init(const char *host_port, Error **errp)
> }
> }
>
> + qapi_free_InetSocketAddress(addr);
> return rdma;
> }
>
Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
next prev parent reply other threads:[~2013-09-24 17:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 13:51 [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak InetSocketAddress Frank
2013-09-24 17:53 ` Michael R. Hines [this message]
2014-02-16 2:33 ` Michael Roth
2014-02-18 2:13 ` Michael R. Hines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5241D1A7.8090008@linux.vnet.ibm.com \
--to=mrhines@linux.vnet.ibm.com \
--cc=frank.yangjie@gmail.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=mrhines@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=yamahata@private.email.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).