From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55317)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1VOWo9-0004nm-VU
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 13:54:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1VOWo1-0001lq-1Y
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 13:53:57 -0400
Received: from e9.ny.us.ibm.com ([32.97.182.139]:37367)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1VOWo0-0001lf-SY
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 13:53:48 -0400
Received: from /spool/local
	by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mrhines@linux.vnet.ibm.com>;
	Tue, 24 Sep 2013 13:53:47 -0400
Message-ID: <5241D1A7.8090008@linux.vnet.ibm.com>
Date: Tue, 24 Sep 2013 13:53:43 -0400
From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <5231C6FC.3060506@gmail.com>
In-Reply-To: <5231C6FC.3060506@gmail.com>
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak
	InetSocketAddress
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Frank <frank.yangjie@gmail.com>
Cc: Isaku Yamahata <yamahata@private.email.ne.jp>, qemu-devel@nongnu.org, Michael R Hines <mrhines@us.ibm.com>, qemu-stable@nongnu.org, lilei@linux.vnet.ibm.com

On 09/12/2013 09:51 AM, Frank wrote:
> It is allocated by g_new0() in inet_parse(), so needs to be freed in qemu_rdma_data_init().
>
> From d7a8d1aad11fbe9af389cf9dd6cee14cc3249b1f Mon Sep 17 00:00:00 2001
> From: Frank Yang <frank.yangjie@gmail.com>
> Date: Thu, 12 Sep 2013 21:37:56 +0800
> Subject: [PATCH] rdma: memory leak InetSocketAddress
>
> Signed-off-by: Frank Yang <frank.yangjie@gmail.com>
> ---
>  migration-rdma.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/migration-rdma.c b/migration-rdma.c
> index 05a155b..bcbe2d2 100644
> --- a/migration-rdma.c
> +++ b/migration-rdma.c
> @@ -2512,6 +2512,7 @@ static void *qemu_rdma_data_init(const char *host_port, Error **errp)
>          }
>      }
>
> +    qapi_free_InetSocketAddress(addr);
>      return rdma;
>  }
>
Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>