From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOrAX-0008VW-UV for qemu-devel@nongnu.org; Wed, 25 Sep 2013 11:38:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOrAR-0001jm-RY for qemu-devel@nongnu.org; Wed, 25 Sep 2013 11:38:25 -0400 Message-ID: <5243035D.4080200@adacore.com> Date: Wed, 25 Sep 2013 17:38:05 +0200 From: Fabien Chouteau MIME-Version: 1.0 References: <1380041161-13266-1-git-send-email-chouteau@adacore.com> <1380041161-13266-4-git-send-email-chouteau@adacore.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] Add ARM registers definitions in Monitor commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Trivial , QEMU Developers , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Luiz Capitulino On 09/25/2013 01:53 AM, Peter Maydell wrote: > > No, I really don't want to see another target #ifdef ladder, please. > Put a 'static const MonitorDef *monitor_defs;' into CPUClass, > and initialize it in each target's class init function, please. > (You'll need to move the appropriate sections of the current > static array in monitor.c plus the per-target functions that > it references into target-*/cpu.c.) Look at gdb_num_core_regs > as an example of where we made this kind of abstraction. > I tried already. Where whould you put the declaration of MonitorDef type? -- Fabien Chouteau