From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37603)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1VOyU7-0006SO-UE
	for qemu-devel@nongnu.org; Wed, 25 Sep 2013 19:27:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1VOyU6-0005xm-4I
	for qemu-devel@nongnu.org; Wed, 25 Sep 2013 19:27:07 -0400
Received: from speedy.comstyle.com ([2001:470:1d:8c::2]:33563
	helo=mail.comstyle.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1VOyU6-0005xX-0B
	for qemu-devel@nongnu.org; Wed, 25 Sep 2013 19:27:06 -0400
Message-ID: <524370C6.3010603@comstyle.com>
Date: Wed, 25 Sep 2013 19:24:54 -0400
From: Brad Smith <brad@comstyle.com>
MIME-Version: 1.0
References: <20130919185352.0000135e@unknown> <523CCF9D.1090002@comstyle.com>
	<20130921183824.00002cd3@unknown>
In-Reply-To: <20130921183824.00002cd3@unknown>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org

On 21/09/13 12:38 PM, Sebastian Herbszt wrote:
> Brad Smith wrote:
>> On 19/09/13 12:53 PM, Sebastian Herbszt wrote:
>>> Brad Smith wrote:
>>>> On 20/01/13 1:12 PM, David Woodhouse wrote:
>>>>> The PCI Firmware Specification apparently requires that the PCI
>>>>> Data Structure be DWORD-aligned. The implementation in OVMF also
>>>>> requires this, so vgabios ROMs don't work there. With this fixed,
>>>>> I can now initialise the VGA ROM from EFI, and EFI can display
>>>>> using INT 10h services.
>>>>>
>>>>> --- vgabios-0.6c/vgabios.c.orig	2013-01-20
>>>>> 11:33:36.138548472 -0600 +++ vgabios-0.6c/vgabios.c
>>>>> 2013-01-20 11:36:26.060270163 -0600 @@ -204,6 +204,7 @@
>>>>> vgabios_website: .byte	0x00
>>>>>
>>>>>     #ifdef PCIBIOS
>>>>> +.align 4 // DWORD alignment required by PCI Firmware
>>>>> Specification vgabios_pci_data:
>>>>>     .ascii "PCIR"
>>>>>     #ifdef CIRRUS
>>>>
>>>> We have had this in the OpenBSD port of QEMU for awhile now. Is it
>>>> possible to have this reviewed and commited?
>>>
>>> This change was commited to upstream vgabios back in February [1].
>>
>> But that has not resulted in it being brought into QEMU.
>
> Gerd, Anthony, care to update QEMU's vgabios repository [1] with
> changes from upstream CVS repository [2]?
>
> [1] http://git.qemu.org/?p=vgabios.git
> [2] http://cvs.savannah.gnu.org/viewvc/?root=vgabios

Any comment?

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.