qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Mark Wu <wudxw@linux.vnet.ibm.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
	Qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'
Date: Thu, 26 Sep 2013 05:42:48 -0600	[thread overview]
Message-ID: <52441DB8.8070704@redhat.com> (raw)
In-Reply-To: <1380160635-15715-1-git-send-email-wudxw@linux.vnet.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]

On 09/25/2013 07:57 PM, Mark Wu wrote:
> Now we have several qemu-ga commands not returning response on success.
> It has been documented in qga/qapi-schema.json already. This patch exposes
> the 'success-response' flag by extending 'guest-info' command. With this
> change, the clients can handle the command response more flexibly.
> 
> Signed-off-by: Mark Wu <wudxw@linux.vnet.ibm.com>
> ---
> Changes:
> v3: 
> 	 1. treat cmd->options as a bitmask instead of single option (per Eric) 
> 	 2. rebase on the patch " Add interface to traverse the qmp command list
>     by QmpCommand" to avoid the O(n2) problem (per Eric and Michael)
> v2: 
>     add the notation 'since 1.7' to the option 'success-response'
>     (per Eric Blake's comments)
> 
>  qga/commands.c       | 1 +
>  qga/qapi-schema.json | 5 ++++-
>  2 files changed, 5 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

  reply	other threads:[~2013-09-26 11:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26  1:57 [Qemu-devel] [PATCH v3] Extend qemu-ga's 'guest-info' command to expose flag 'success-response' Mark Wu
2013-09-26 11:42 ` Eric Blake [this message]
2013-09-27 16:23 ` Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52441DB8.8070704@redhat.com \
    --to=eblake@redhat.com \
    --cc=Qemu-devel@nongnu.org \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=wudxw@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).