From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VP9yG-0002E6-4p for Qemu-devel@nongnu.org; Thu, 26 Sep 2013 07:43:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VP9yB-0005Hi-4y for Qemu-devel@nongnu.org; Thu, 26 Sep 2013 07:43:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VP9yA-0005HY-TI for Qemu-devel@nongnu.org; Thu, 26 Sep 2013 07:42:55 -0400 Message-ID: <52441DB8.8070704@redhat.com> Date: Thu, 26 Sep 2013 05:42:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380160635-15715-1-git-send-email-wudxw@linux.vnet.ibm.com> In-Reply-To: <1380160635-15715-1-git-send-email-wudxw@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OrS6iBODTlTK6adWBGjM4UnU4mBGAJWwI" Subject: Re: [Qemu-devel] [PATCH v3] Extend qemu-ga's 'guest-info' command to expose flag 'success-response' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Wu Cc: Michael Roth , Qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OrS6iBODTlTK6adWBGjM4UnU4mBGAJWwI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/25/2013 07:57 PM, Mark Wu wrote: > Now we have several qemu-ga commands not returning response on success.= > It has been documented in qga/qapi-schema.json already. This patch expo= ses > the 'success-response' flag by extending 'guest-info' command. With thi= s > change, the clients can handle the command response more flexibly. >=20 > Signed-off-by: Mark Wu > --- > Changes: > v3:=20 > 1. treat cmd->options as a bitmask instead of single option (per Eric= )=20 > 2. rebase on the patch " Add interface to traverse the qmp command li= st > by QmpCommand" to avoid the O(n2) problem (per Eric and Michael) > v2:=20 > add the notation 'since 1.7' to the option 'success-response' > (per Eric Blake's comments) >=20 > qga/commands.c | 1 + > qga/qapi-schema.json | 5 ++++- > 2 files changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OrS6iBODTlTK6adWBGjM4UnU4mBGAJWwI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSRB24AAoJEKeha0olJ0NqFnMIAJ0ZtPieoHyeQXdCeGvi7ibz 4wIIkRssSpRF9hzzUJzhrOb59lSiNd7FBU7h9w1ZEIKUxjpxs4WccjglUYXm9Mcw MlI3teb1+XllYj66qT7wOCW0dIFECEbVs3y4nvPk1kqJJWTtzryEsnbOijWlg/AN rAr30Kh3t5iidGKWNeqOyHiPLKiIJZpgvDdUXmbgH5iUIfV9bfs+KE/lXTme3tJQ oy9NXE2VTKQ8F9eh/Qc1efTsNht4+mC99bqGh5rUcjU+cbBRLmyV6WQsYDUDrVDs gZgcKavCSiLQ2L3urm40Wg/a9+kwiAO6p4krrpq5ClZQboJeCpv1wSyqAl/VZMU= =lGfw -----END PGP SIGNATURE----- --OrS6iBODTlTK6adWBGjM4UnU4mBGAJWwI--