From: Paolo Bonzini <pbonzini@redhat.com>
To: Lei Li <lilei@linux.vnet.ibm.com>
Cc: aarcange@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org,
mrhines@linux.vnet.ibm.com, mdroth@linux.vnet.ibm.com,
anthony@codemonkey.ws, lagarcia@br.ibm.com,
rcj@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM
Date: Thu, 26 Sep 2013 14:54:58 +0200 [thread overview]
Message-ID: <52442EA2.7020300@redhat.com> (raw)
In-Reply-To: <52442C16.7000200@linux.vnet.ibm.com>
Il 26/09/2013 14:44, Lei Li ha scritto:
>>
>> The basis of your code will still be the socket-based QEMUFile, but
>> you'll need your own QEMUFile since you're adding Unix-specific
>> functionality. For this it is not a problem to have two copies the
>> QEMUFile code for sockets, one in savevm.c and one in migration-unix.c.
>
> Have two copies of the QEMUFile code for sockets, do you mean in my own
> QEMUFile, say QEMUFilePipe, includes both the copy of QEMUFileSocket
> code (like get_fd, get_buffer, writev_buffer..) and the Unix-specific
> functionality code that override these three hooks like your suggestions
> above?
Yes (the name could be either QEMUFilePipe or QEMUFileUnix, I guess).
> I guess 'migration-unix.c' you typed is 'migration-local.c', right?
I wasn't sure of the reason why 'migration-unix.c' and
'migration-local.c' were split, since now the choice is done with a
capability rather than a different protocol.
Thanks,
Paolo
next prev parent reply other threads:[~2013-09-26 12:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 14:32 [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM Lei Li
2013-09-25 14:32 ` [Qemu-devel] [PATCH 1/8] migration-local: add pipe protocol for QEMUFileOps Lei Li
2013-09-25 14:32 ` [Qemu-devel] [PATCH 2/8] migration-loca: add qemu_fopen_pipe() Lei Li
2013-09-25 14:32 ` [Qemu-devel] [PATCH 3/8] migration-local: add send_pipefd() Lei Li
2013-09-25 14:32 ` [Qemu-devel] [PATCH 4/8] migration-local: add recv_pipefd() Lei Li
2013-09-25 14:32 ` [Qemu-devel] [PATCH 5/8] QAPI: introduce magration capability unix_page_flipping Lei Li
2013-09-25 14:32 ` [Qemu-devel] [PATCH 6/8] migration: add migrate_unix_page_flipping() Lei Li
2013-09-25 14:32 ` [Qemu-devel] [PATCH 7/8] migration-unix: side channel support on unix outgoing Lei Li
2013-09-25 14:32 ` [Qemu-devel] [PATCH 8/8] migration-unix: side channel support on unix incoming Lei Li
2013-09-25 15:02 ` [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM Paolo Bonzini
2013-09-26 12:44 ` Lei Li
2013-09-26 12:54 ` Paolo Bonzini [this message]
2013-10-03 4:03 ` Lei Li
2013-10-03 8:23 ` Paolo Bonzini
2013-10-03 10:28 ` Lei Li
2013-10-03 10:34 ` Paolo Bonzini
2013-10-03 13:29 ` Lei Li
2013-10-03 13:34 ` Paolo Bonzini
2013-10-03 13:37 ` Lei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52442EA2.7020300@redhat.com \
--to=pbonzini@redhat.com \
--cc=aarcange@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=lagarcia@br.ibm.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mrhines@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rcj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).