From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPCMM-0008S8-8x for qemu-devel@nongnu.org; Thu, 26 Sep 2013 10:16:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPCME-0000Oe-Ru for qemu-devel@nongnu.org; Thu, 26 Sep 2013 10:16:02 -0400 Received: from mail-pd0-x236.google.com ([2607:f8b0:400e:c02::236]:40467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPCME-0000OP-FK for qemu-devel@nongnu.org; Thu, 26 Sep 2013 10:15:54 -0400 Received: by mail-pd0-f182.google.com with SMTP id r10so1212284pdi.41 for ; Thu, 26 Sep 2013 07:15:53 -0700 (PDT) Sender: Richard Henderson Message-ID: <52444195.30203@twiddle.net> Date: Thu, 26 Sep 2013 07:15:49 -0700 From: Richard Henderson MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-i386: fix translation of sse {, u}comis{s, d} instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nathan Froyd Cc: qemu-devel , froydnj@gmail.com On 09/25/2013 01:20 PM, Nathan Froyd wrote: > While the generic SSE translation codepath contains special logic to use > 32-bit or 64-bit memory operands for some instructions, this logic doesn't > catch the SSE {,u}comis{s,d} instructions. This oversight leads to too > many bytes being read when those instructions use memory operands, which > can in turn lead to page faults. > > The fix is simple: add a special case for these instructions. It did not > fit cleanly into the existing case, so some cut-and-paste was necesary. > > Signed-off-by: Nathan Froyd > --- > target-i386/translate.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) Reviewed-by: Richard Henderson r~