From: Fabien Chouteau <chouteau@adacore.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "QEMU Trivial" <qemu-trivial@nongnu.org>,
"Luiz Capitulino" <lcapitulino@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 3/3] Add ARM registers definitions in Monitor commands
Date: Thu, 26 Sep 2013 16:50:50 +0200 [thread overview]
Message-ID: <524449CA.5080706@adacore.com> (raw)
In-Reply-To: <CAFEAcA8EfFnyvXyqUVcQNz3NR-sf9dgtEiiK92p4Be0nUbd_7g@mail.gmail.com>
On 09/26/2013 02:05 AM, Peter Maydell wrote:
> On 26 September 2013 01:29, Fabien Chouteau <chouteau@adacore.com> wrote:
>> On 09/25/2013 05:51 PM, Peter Maydell wrote:
>>> On 26 September 2013 00:38, Fabien Chouteau <chouteau@adacore.com> wrote:
>>> It doesn't matter very much, but monitor.h seems the obvious
>>> place. You probably don't want qom/cpu.h to have to drag in
>>> monitor.h so a 'struct MonitorDef;' forward declaration in cpu.h
>>> will let you avoid that (we do that already for a few other structs).
>>
>> I think that's what I did. I think the problem was to include
>> 'monitor.h' in 'target-*/cpu.c'.
>
> Why doesn't that work?
>
The problem is use of 'target_long' in 'monitor.h'.
--
Fabien Chouteau
next prev parent reply other threads:[~2013-09-26 14:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 16:45 [Qemu-devel] [PATCH 0/3] Few minor improvements of monitor disas command (v2) Fabien Chouteau
2013-09-24 16:45 ` [Qemu-devel] [PATCH 1/3] Fix coding style Fabien Chouteau
2013-09-24 17:33 ` Andreas Färber
2013-09-24 16:46 ` [Qemu-devel] [PATCH 2/3] Improve Monitor disas with symbol lookup Fabien Chouteau
2013-09-24 16:46 ` [Qemu-devel] [PATCH 3/3] Add ARM registers definitions in Monitor commands Fabien Chouteau
2013-09-24 23:53 ` Peter Maydell
2013-09-25 15:38 ` Fabien Chouteau
2013-09-25 15:51 ` Peter Maydell
2013-09-25 16:29 ` Fabien Chouteau
2013-09-26 0:05 ` Peter Maydell
2013-09-26 14:50 ` Fabien Chouteau [this message]
2013-09-26 15:28 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524449CA.5080706@adacore.com \
--to=chouteau@adacore.com \
--cc=afaerber@suse.de \
--cc=lcapitulino@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).