From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPTtU-0002AF-KQ for qemu-devel@nongnu.org; Fri, 27 Sep 2013 04:59:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPTtP-0008Qm-I5 for qemu-devel@nongnu.org; Fri, 27 Sep 2013 04:59:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPTtP-0008Qe-9S for qemu-devel@nongnu.org; Fri, 27 Sep 2013 04:59:19 -0400 Message-ID: <524548F7.4010605@redhat.com> Date: Fri, 27 Sep 2013 10:59:35 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1379558748-13808-1-git-send-email-aik@ozlabs.ru> <52453B97.2000700@ozlabs.ru> In-Reply-To: <52453B97.2000700@ozlabs.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] kvm: add set_one_reg/get_one_reg helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Peter Maydell , qemu-devel@nongnu.org Il 27/09/2013 10:02, Alexey Kardashevskiy ha scritto: > On 09/19/2013 12:45 PM, Alexey Kardashevskiy wrote: >> This adds QEMU wrappers for KVM_SET_ONE_REG/KVM_GET_ONE_REG ioctls. > > Ping? > > >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> Changes: >> v3: >> * changed comments >> >> v2: >> * added Doc Comments >> * removed error_print >> --- >> include/sysemu/kvm.h | 21 +++++++++++++++++++++ >> kvm-all.c | 18 ++++++++++++++++++ >> 2 files changed, 39 insertions(+) >> >> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h >> index c7bc07b..9080ffe 100644 >> --- a/include/sysemu/kvm.h >> +++ b/include/sysemu/kvm.h >> @@ -319,4 +319,25 @@ int kvm_irqchip_remove_irqfd_notifier(KVMState *s, EventNotifier *n, int virq); >> void kvm_pc_gsi_handler(void *opaque, int n, int level); >> void kvm_pc_setup_irq_routing(bool pci_enabled); >> void kvm_init_irq_routing(KVMState *s); >> + >> +/** >> + * kvm_set_one_reg - set a register value in KVM via KVM_SET_ONE_REG ioctl >> + * @id: The register ID >> + * @addr: The pointer to a value must point to a variable of the correct >> + * type/size for the register being accessed. >> + * >> + * Returns: 0 on success, or a negative errno on failure. >> + */ >> +int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr); >> + >> +/** >> + * kvm_get_one_reg - get a register value from KVM via KVM_GET_ONE_REG ioctl >> + * @id: The register ID >> + * @addr: The pointer to a value must point to a variable of the correct >> + * type/size for the register being accessed. >> + * >> + * Returns: 0 on success, or a negative errno on failure. >> + */ >> +int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr); >> + >> #endif >> diff --git a/kvm-all.c b/kvm-all.c >> index ded7fc8..cdc32ec 100644 >> --- a/kvm-all.c >> +++ b/kvm-all.c >> @@ -2049,3 +2049,21 @@ int kvm_on_sigbus(int code, void *addr) >> { >> return kvm_arch_on_sigbus(code, addr); >> } >> + >> +int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr) >> +{ >> + struct kvm_one_reg reg = { >> + .id = id, >> + .addr = (uintptr_t)addr, >> + }; >> + return kvm_vcpu_ioctl(cs, KVM_SET_ONE_REG, ®); >> +} >> + >> +int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr) >> +{ >> + struct kvm_one_reg reg = { >> + .id = id, >> + .addr = (uintptr_t)addr, >> + }; >> + return kvm_vcpu_ioctl(cs, KVM_GET_ONE_REG, ®); >> +} >> > > Acked-by: Paolo Bonzini Include it with the acked-by together with the first patch that needs it. Alex can pick it up. Paolo