Re: [Qemu-devel] [v2 30/71] hw/ide/Kconfig: Add Kconfig file

[Paolo Bonzini <pbonzini@redhat.com>]

Il 27/09/2013 13:11, Stefan Hajnoczi ha scritto:
> On Fri, Sep 27, 2013 at 04:30:51AM +0200, Ákos Kovács wrote:
>> diff --git a/hw/net/Kconfig b/hw/net/Kconfig
>> new file mode 100644
>> index 0000000..19ca549
>> --- /dev/null
>> +++ b/hw/net/Kconfig
> 
> This should be a separate patch.
> 
>> @@ -0,0 +1,74 @@
>> +menu "Network devices"
>> +    config DP8393X
>> +        bool
>> +
>> +    config XEN_BACKEND
>> +        bool
> 
> Should all devices have a "depends on $BUS" so they can only be
> configured if the bus is also configured?

Yes, but DP8393X is not qdevified.

That said, XEN_BACKEND should be in hw/xen, not here.

Paolo