From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPW82-0001hx-JN for qemu-devel@nongnu.org; Fri, 27 Sep 2013 07:22:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPW7u-0000YB-1u for qemu-devel@nongnu.org; Fri, 27 Sep 2013 07:22:34 -0400 Received: from mail-qe0-x229.google.com ([2607:f8b0:400d:c02::229]:43519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPW7t-0000Y5-UP for qemu-devel@nongnu.org; Fri, 27 Sep 2013 07:22:25 -0400 Received: by mail-qe0-f41.google.com with SMTP id 1so1710941qee.14 for ; Fri, 27 Sep 2013 04:22:25 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <52456A82.3060301@redhat.com> Date: Fri, 27 Sep 2013 13:22:42 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1380249092-4775-1-git-send-email-akoskovacs@gmx.com> <1380249092-4775-31-git-send-email-akoskovacs@gmx.com> <20130927111154.GG9972@stefanha-thinkpad.redhat.com> In-Reply-To: <20130927111154.GG9972@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [v2 30/71] hw/ide/Kconfig: Add Kconfig file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: =?ISO-8859-1?Q?=C1kos_Kov=E1cs?= , qemu-devel@nongnu.org Il 27/09/2013 13:11, Stefan Hajnoczi ha scritto: > On Fri, Sep 27, 2013 at 04:30:51AM +0200, Ákos Kovács wrote: >> diff --git a/hw/net/Kconfig b/hw/net/Kconfig >> new file mode 100644 >> index 0000000..19ca549 >> --- /dev/null >> +++ b/hw/net/Kconfig > > This should be a separate patch. > >> @@ -0,0 +1,74 @@ >> +menu "Network devices" >> + config DP8393X >> + bool >> + >> + config XEN_BACKEND >> + bool > > Should all devices have a "depends on $BUS" so they can only be > configured if the bus is also configured? Yes, but DP8393X is not qdevified. That said, XEN_BACKEND should be in hw/xen, not here. Paolo