From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPb8P-0006BE-R5 for qemu-devel@nongnu.org; Fri, 27 Sep 2013 12:43:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPb8K-0002rT-ET for qemu-devel@nongnu.org; Fri, 27 Sep 2013 12:43:17 -0400 Received: from smtp.mail.uni-mannheim.de ([134.155.96.80]:39445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPb8K-0002rP-7e for qemu-devel@nongnu.org; Fri, 27 Sep 2013 12:43:12 -0400 Message-ID: <5245B5A2.8000509@weilnetz.de> Date: Fri, 27 Sep 2013 18:43:14 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1343035544-11101-1-git-send-email-initcrash@gmail.com> <500D7BCA.9090409@weilnetz.de> <524557A6.903@redhat.com> In-Reply-To: <524557A6.903@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] eepro100: fix simplified mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , christian schilling Cc: qemu-devel@nongnu.org Am 27.09.2013 12:02, schrieb Paolo Bonzini: > Il 24/07/2012 09:49, christian schilling ha scritto: >> On Mon, Jul 23, 2012 at 6:28 PM, Stefan Weil wrote: >>> Am 23.07.2012 11:25, schrieb initcrash@gmail.com: >>>> A driver using simplified mode that works on real hardware >>>> did not work in qemu. >>>> >>>> Signed-off-by: Christian Schilling >>>> --- >>>> hw/eepro100.c | 7 +++++++ >>>> 1 files changed, 7 insertions(+), 0 deletions(-) >>>> >>> >>> Do you really think that's a trivial patch? >> It's only three lines plus comments, but ok small != trivial. >> >>> I have a different fix for simplified mode in my QEMU tree: >>> >>> http://repo.or.cz/w/qemu/ar7.git/blob/HEAD:/hw/eepro100.c >>> >>> That version is implemented according to the Intel specifications >>> and avoids hacks for specific guest drivers. >> My fix isn't a hack for a specific guest driver, but is also in >> accordance with the >> intel specs. >> >>> Maybe you can give it a try. >> I have, it does work. >> Overall the code look better to me, but one thing irritates me: >> The comment on line 821 contradicts the trace on 830 and 833. >> in fact i don't understand the code from 820 to 340. It seems to me it should >> handle extended flexible TCBs, but if it does what does the code >> following line 855 do? > Anything new about this one-year-old patch? > > Paolo No, there isn't, sorry. I still have to send a patch which merges my modifications into official QEMU. And I also still wish a good set of test cases which can be used for all nic emulations. My version of eepro100.c is in http://repo.or.cz/w/qemu/ar7.git. Regards, Stefan